[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #834: tools/zipme.sh: Let major.minor.patch argument optional

[GitBox <gi...@apache.org>]

xiaoxiang781216 edited a comment on issue #834:
URL: https://github.com/apache/incubator-nuttx/pull/834#issuecomment-617185271


   > > It is possible to find the right tag for a particular release, #757 has the detailed discussion.
   > 
   > Yes, but only if the tag exists.
   > 
   
   gitver.sh also assume the tag is created before execution. There isn't difference between gitver.sh and version.sh from this point of view.
   
   > What I am saying is without supplying the version string to the script we relay solely on the tags. The latest tag needs to match the version we are trying to create the tarballs for.
   
   Yes, I agree. My suggestion is that it's better to put the algorithm to find the right tag in one place instead two(version.sh and gitver.sh).
   
   > This may not be an issue on its own, I just wanted to make sure that we all agree that a manual tag will be needed.
   
   Yes, here are two issues:
   1.How to find the right tag? My proprose is that merging gitver.sh logic into version.sh.
   2.How to create the tag?
      Created by the release manager manually, then the release process become:
      a.The release manager merge the PR with critical patch into the release branch
      b.The release manager create the right tag
      c.The release manager run zipme.sh to generate the package
      Or create(increase patch number) in package.yaml, then the most action can run automatically:
      a.The release manager merge the PR with critical patch into the release branch
      b.package.yaml(or call some script) create a new tag which point to the header of release branch
      c.package.yaml run zipme.sh to generate the package
   
   The release manager have to sign the package and send the email manually


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org