[GitHub] zookeeper issue #528: ZOOKEEPER-3034 Facing issues while building from sourc...

[anmolnar <gi...@git.apache.org>]

Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/528
  
    @phunt I ran a few cycles with the curl commit that you linked and here're my results:
    
    - there's no such thing with autotools that "check for a macro existence and use it if present", because macros must always be extracted even if they behind an if condition,
    - Curl circumvents this behaviour by directly calling commands like `pkg-config --libs MYLIB` instead of using the macro that package maintainer provides,
    - as a consequence we either can use the old AM_PATH_CPPUNIT macro or the new pkg-config macro, but not both.
    
    I'm not a fan of Curl approach: it runs custom code essentially which seems to me fragile.
    
    To make an end to this conversion I think we have 2 options.
    1. Replace the old macro with the new one and commit it to trunk only --> we stop supporting the old way from 3.6.0 and pkg-config will be required. Reward: ZK builds on new systems like Ubuntu 18.04.
    2. Don't do anything. 


---