You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by John Burwell <jb...@basho.com> on 2013/07/18 16:47:08 UTC
Re: [ACS42] Release Status Update
Mike,
Have you posted the diff with the resolved second round issues for the SolidFire patch to Review Board?
Thanks,
-John
On Jun 28, 2013, at 12:49 PM, Mike Tutkowski <mi...@solidfire.com> wrote:
> Hi John,
>
> OK, this sounds good.
>
> I updated from master yesterday and was resolving some (major) conflicts last night and this morning. I want to get in some more testing before I commit.
>
> Sounds good on the points you make. It should be, as you say, easy to resolve them.
>
> Thanks,
> Mike
>
>
> On Fri, Jun 28, 2013 at 9:50 AM, John Burwell <jb...@basho.com> wrote:
> Mike,
>
> I (finally) completed the review of the patch. The TL;DR is that I am removing my -1 on the patch so long as a supplemental patch that addresses the issues raised is submitted to Review Board for a third review . The following items are concern me, and must be addressed before release:
>
> Error handling in the patch catches and throws Exception too broadly. There is also no attempt in methods manipulating the hypervisor to back out partial changes. I am concerned that errors could put a hypervisor in an inconsistent state.
> There is a manually built thread pool in the VMwareResource. What is driving the use of multiple threads? It feels like pre-mature optimization. If it is necessary, ExceutorService should be used.
> There are unresolved TODOs in the PrimaryDataStoreImpl where getters are not returning internal state as expected
>
> Since we had Collab this week and I couldn't review it, I don't think we should prevent the feature from coming into the release. I also think these issues can addressed rather quickly next week. Finally, this patch has had two rounds of review, so I don't expect the need for a fourth round. As such, let's get it merged and do the last bits of cleanup next week.
>
> Thanks,
> -John
>
> On Jun 26, 2013, at 11:42 PM, Mike Tutkowski <mi...@solidfire.com> wrote:
>
>> Hey John,
>>
>> I know you were at a CloudStack Meetup today, but any thoughts on when we are going to get Storage QoS (the SolidFire plug-in) merged into master?
>>
>> Thanks!
>>
>>
>> On Wed, Jun 26, 2013 at 9:37 PM, Animesh Chaturvedi <an...@citrix.com> wrote:
>> Folks
>>
>> The status for features or improvement is depicted in table below
>>
>> |-----------------------------+-----------+-----------|
>> | New Features / Improvements | This Week | TwoWeekAgo|
>> |-----------------------------+-----------+-----------|
>> | Closed | 8 | 7 |
>> | Resolved | 56 | 52 |
>> | In Progress | 13 | 17 |
>> | Reopened | 1 | 2 |
>> | Ready To Review | 2 | 2 |
>> | Open | 22 | 23 |
>> |-----------------------------+-----------+-----------|
>> | Total | 102 | 103 |
>> |-----------------------------+-----------+-----------|
>>
>> We are now just two days away from feature freeze, but still there are many open tickets. If the feature or improvement is unlikely to be wrapped up by 6/28 it should be moved out of 4.2
>>
>>
>>
>> As for bugs here is a summary for this week:
>>
>> Bugs | This Week | Two Week Ago
>> -----------------+-----------+----------+-------+-------+-----------+----------+-------+-------
>> | Blocker Critical Major Total | Blocker Critical Major Total
>> -----------------+-----------+----------+-------+-------+-----------+----------+-------+-------
>> Incoming | 4 19 37 68 | 8 20 29 60
>> Outgoing | 19 42 34 102 | 18 10 42 76
>> Open Unassigned | 4 27 116 184 | 7 35 93 166
>> Open Total | 17 62 223 365 | 19 74 192 345
>>
>>
>>
>> The outgoing defect fix rate is much higher than incoming defects which is a good sign but we still have large number of open defects. We have a large number of unassigned open defects and it is increasing every week. If you are interested in helping out on defects please check the release dashboard http://s.apache.org/M5k
>>
>> The resolved but not verified /closed has gone up now to 458 and needs to be contained. If you reported a issues and fixed it yourself but did not close it please take a moment to close the defect after verification.
>>
>> I also wanted to call out that there are large number of patches on review board. If you are reviewer please attend to your reviews. If you are a submitter and want your contribution to be included in 4.2 please follow through with your reviewers.
>>
>>
>> Comments/feedback on this release status update are appreciated. You can always visit the 4.2 Release dashboard http://s.apache.org/M5k for the current status.
>>
>>
>> Thanks
>> Animesh
>>
>>
>>
>> --
>> Mike Tutkowski
>> Senior CloudStack Developer, SolidFire Inc.
>> e: mike.tutkowski@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the cloud™
>
>
>
>
> --
> Mike Tutkowski
> Senior CloudStack Developer, SolidFire Inc.
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud™
Re: [ACS42] Release Status Update
Posted by Mike Tutkowski <mi...@solidfire.com>.
Hi John,
Oh, not yet...I am still working on one of your VMware issues. It should be
done today or tomorrow, I expect.
Thanks
On Thu, Jul 18, 2013 at 8:47 AM, John Burwell <jb...@basho.com> wrote:
> Mike,
>
> Have you posted the diff with the resolved second round issues for the
> SolidFire patch to Review Board?
>
> Thanks,
> -John
>
> On Jun 28, 2013, at 12:49 PM, Mike Tutkowski <mi...@solidfire.com>
> wrote:
>
> Hi John,
>
> OK, this sounds good.
>
> I updated from master yesterday and was resolving some (major) conflicts
> last night and this morning. I want to get in some more testing before I
> commit.
>
> Sounds good on the points you make. It should be, as you say, easy to
> resolve them.
>
> Thanks,
> Mike
>
>
> On Fri, Jun 28, 2013 at 9:50 AM, John Burwell <jb...@basho.com> wrote:
>
>> Mike,
>>
>> I (finally) completed the review of the patch. The TL;DR is that I am
>> removing my -1 on the patch so long as a supplemental patch that addresses
>> the issues raised is submitted to Review Board for a third review . The
>> following items are concern me, and must be addressed before release:
>>
>>
>> - Error handling in the patch catches and throws Exception too
>> broadly. There is also no attempt in methods manipulating the hypervisor
>> to back out partial changes. I am concerned that errors could put a
>> hypervisor in an inconsistent state.
>> - There is a manually built thread pool in the VMwareResource. What
>> is driving the use of multiple threads? It feels like pre-mature
>> optimization. If it is necessary, ExceutorService should be used.
>> - There are unresolved TODOs in the PrimaryDataStoreImpl where
>> getters are not returning internal state as expected
>>
>>
>> Since we had Collab this week and I couldn't review it, I don't think we
>> should prevent the feature from coming into the release. I also think
>> these issues can addressed rather quickly next week. Finally, this patch
>> has had two rounds of review, so I don't expect the need for a fourth
>> round. As such, let's get it merged and do the last bits of cleanup next
>> week.
>>
>> Thanks,
>> -John
>>
>> On Jun 26, 2013, at 11:42 PM, Mike Tutkowski <
>> mike.tutkowski@solidfire.com> wrote:
>>
>> Hey John,
>>
>> I know you were at a CloudStack Meetup today, but any thoughts on when we
>> are going to get Storage QoS (the SolidFire plug-in) merged into master?
>>
>> Thanks!
>>
>>
>> On Wed, Jun 26, 2013 at 9:37 PM, Animesh Chaturvedi <
>> animesh.chaturvedi@citrix.com> wrote:
>>
>>> Folks
>>>
>>> The status for features or improvement is depicted in table below
>>>
>>> |-----------------------------+-----------+-----------|
>>> | New Features / Improvements | This Week | TwoWeekAgo|
>>> |-----------------------------+-----------+-----------|
>>> | Closed | 8 | 7 |
>>> | Resolved | 56 | 52 |
>>> | In Progress | 13 | 17 |
>>> | Reopened | 1 | 2 |
>>> | Ready To Review | 2 | 2 |
>>> | Open | 22 | 23 |
>>> |-----------------------------+-----------+-----------|
>>> | Total | 102 | 103 |
>>> |-----------------------------+-----------+-----------|
>>>
>>> We are now just two days away from feature freeze, but still there are
>>> many open tickets. If the feature or improvement is unlikely to be wrapped
>>> up by 6/28 it should be moved out of 4.2
>>>
>>>
>>>
>>> As for bugs here is a summary for this week:
>>>
>>> Bugs | This Week | Two Week Ago
>>>
>>> -----------------+-----------+----------+-------+-------+-----------+----------+-------+-------
>>> | Blocker Critical Major Total | Blocker
>>> Critical Major Total
>>>
>>> -----------------+-----------+----------+-------+-------+-----------+----------+-------+-------
>>> Incoming | 4 19 37 68 | 8
>>> 20 29 60
>>> Outgoing | 19 42 34 102 | 18
>>> 10 42 76
>>> Open Unassigned | 4 27 116 184 | 7
>>> 35 93 166
>>> Open Total | 17 62 223 365 | 19
>>> 74 192 345
>>>
>>>
>>>
>>> The outgoing defect fix rate is much higher than incoming defects which
>>> is a good sign but we still have large number of open defects. We have a
>>> large number of unassigned open defects and it is increasing every week. If
>>> you are interested in helping out on defects please check the release
>>> dashboard http://s.apache.org/M5k
>>>
>>> The resolved but not verified /closed has gone up now to 458 and needs
>>> to be contained. If you reported a issues and fixed it yourself but did not
>>> close it please take a moment to close the defect after verification.
>>>
>>> I also wanted to call out that there are large number of patches on
>>> review board. If you are reviewer please attend to your reviews. If you are
>>> a submitter and want your contribution to be included in 4.2 please follow
>>> through with your reviewers.
>>>
>>>
>>> Comments/feedback on this release status update are appreciated. You can
>>> always visit the 4.2 Release dashboard http://s.apache.org/M5k for the
>>> current status.
>>>
>>>
>>> Thanks
>>> Animesh
>>>
>>
>>
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkowski@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the cloud<http://solidfire.com/solution/overview/?video=play>
>> *™*
>>
>>
>>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud<http://solidfire.com/solution/overview/?video=play>
> *™*
>
>
>
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud<http://solidfire.com/solution/overview/?video=play>
*™*