[GitHub] [logging-log4j2] jvz commented on a change in pull request #589: LOG4J2-3174: Wrong subject on mail when it depends on the LogEvent

[GitBox <gi...@apache.org>]

jvz commented on a change in pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589#discussion_r731254376



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##########
@@ -273,10 +273,11 @@ protected MimeMultipart getMimeMultipart(final byte[] encodedBytes, final Intern
         return mp;
     }
 
-    protected void sendMultipartMessage(final MimeMessage msg, final MimeMultipart mp) throws MessagingException {
+    protected void sendMultipartMessage(final MimeMessage msg, final MimeMultipart mp, final String subject) throws MessagingException {

Review comment:
       Being a manager class that's meant to be extended or used by plugin authors means it should attempt to preserve compatibility where possible. Could this be done by having the old method call a new one with a default value?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org