You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/03/08 04:53:22 UTC
[GitHub] [incubator-doris] 924060929 commented on a change in pull request #5425: [Hll][Be][Bug-Fix] Resolve be crash when aggregate 160 hll items(#5424)
924060929 commented on a change in pull request #5425:
URL: https://github.com/apache/incubator-doris/pull/5425#discussion_r589168983
##########
File path: be/src/olap/hll.cpp
##########
@@ -164,7 +164,7 @@ size_t HyperLogLog::serialize(uint8_t* dst) const {
break;
}
case HLL_DATA_EXPLICIT: {
- DCHECK(_hash_set.size() < HLL_EXPLICIT_INT64_NUM)
+ DCHECK(_hash_set.size() <= HLL_EXPLICIT_INT64_NUM)
Review comment:
I use BUILD_TYPE=DEBUG to test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org