You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Andrew Pilloud <ap...@google.com> on 2018/09/11 20:35:46 UTC
Spotless broken on master
Looks like the Java PreCommit is broken due to a commit manually merged to
master. Thanks to Huygaa for finding it in our unstable tests.
Fix is here, I will merge when tests pass:
https://github.com/apache/beam/pull/6364
Andrew
Re: Spotless broken on master
Posted by Ismaël Mejía <ie...@gmail.com>.
Thanks Thomas, I will use that one now.
On Wed, Sep 12, 2018 at 12:35 PM Thomas Weise <th...@apache.org> wrote:
>
> The equivalent target to run should be "check" - see https://beam.apache.org/contribute/
>
>
> On Wed, Sep 12, 2018 at 6:01 AM Ismaël Mejía <ie...@gmail.com> wrote:
>>
>> Thanks for pointing this out Andrew (and sorry for the inconvenience).
>> This is indeed a non intuitive behavior of our build system (at least
>> for someone coming from maven):
>>
>> This one checks spotless:
>>
>> ./gradlew clean build -p sdks/java/io/kinesis
>>
>> This one does not:
>>
>> ./gradlew clean test -p sdks/java/io/kinesis
>>
>> I am wondering if we should align them to avoiding this kind of issues
>> in the future, and also what is the closest equivalent of the old ‘mvn
>> clean verify -Prelease -pl ...’ to validate a specific module locally
>> to avoid running the full build for a minor case like this one but
>> without the fear of breaking stuff.
>> On Tue, Sep 11, 2018 at 11:55 PM Andrew Pilloud <ap...@google.com> wrote:
>> >
>> > I don't think spotless is included in the default test target. Jenkins runs a more expanded ':javaPreCommit' gradle target.
>> >
>> > Andrew
>> >
>> > On Tue, Sep 11, 2018 at 2:32 PM Ismaël Mejía <ie...@gmail.com> wrote:
>> >>
>> >> Mmm this is weird, I tested this locally and passed without issue, I
>> >> am wondering how could this happen.
>> >> Thanks anyway for the quick fix.
Re: Spotless broken on master
Posted by Thomas Weise <th...@apache.org>.
The equivalent target to run should be "check" - see
https://beam.apache.org/contribute/
On Wed, Sep 12, 2018 at 6:01 AM Ismaël Mejía <ie...@gmail.com> wrote:
> Thanks for pointing this out Andrew (and sorry for the inconvenience).
> This is indeed a non intuitive behavior of our build system (at least
> for someone coming from maven):
>
> This one checks spotless:
>
> ./gradlew clean build -p sdks/java/io/kinesis
>
> This one does not:
>
> ./gradlew clean test -p sdks/java/io/kinesis
>
> I am wondering if we should align them to avoiding this kind of issues
> in the future, and also what is the closest equivalent of the old ‘mvn
> clean verify -Prelease -pl ...’ to validate a specific module locally
> to avoid running the full build for a minor case like this one but
> without the fear of breaking stuff.
> On Tue, Sep 11, 2018 at 11:55 PM Andrew Pilloud <ap...@google.com>
> wrote:
> >
> > I don't think spotless is included in the default test target. Jenkins
> runs a more expanded ':javaPreCommit' gradle target.
> >
> > Andrew
> >
> > On Tue, Sep 11, 2018 at 2:32 PM Ismaël Mejía <ie...@gmail.com> wrote:
> >>
> >> Mmm this is weird, I tested this locally and passed without issue, I
> >> am wondering how could this happen.
> >> Thanks anyway for the quick fix.
>
Re: Spotless broken on master
Posted by Ismaël Mejía <ie...@gmail.com>.
Thanks for pointing this out Andrew (and sorry for the inconvenience).
This is indeed a non intuitive behavior of our build system (at least
for someone coming from maven):
This one checks spotless:
./gradlew clean build -p sdks/java/io/kinesis
This one does not:
./gradlew clean test -p sdks/java/io/kinesis
I am wondering if we should align them to avoiding this kind of issues
in the future, and also what is the closest equivalent of the old ‘mvn
clean verify -Prelease -pl ...’ to validate a specific module locally
to avoid running the full build for a minor case like this one but
without the fear of breaking stuff.
On Tue, Sep 11, 2018 at 11:55 PM Andrew Pilloud <ap...@google.com> wrote:
>
> I don't think spotless is included in the default test target. Jenkins runs a more expanded ':javaPreCommit' gradle target.
>
> Andrew
>
> On Tue, Sep 11, 2018 at 2:32 PM Ismaël Mejía <ie...@gmail.com> wrote:
>>
>> Mmm this is weird, I tested this locally and passed without issue, I
>> am wondering how could this happen.
>> Thanks anyway for the quick fix.
Re: Spotless broken on master
Posted by Andrew Pilloud <ap...@google.com>.
I don't think spotless is included in the default test target. Jenkins runs
a more expanded ':javaPreCommit' gradle target.
Andrew
On Tue, Sep 11, 2018 at 2:32 PM Ismaël Mejía <ie...@gmail.com> wrote:
> Mmm this is weird, I tested this locally and passed without issue, I
> am wondering how could this happen.
> Thanks anyway for the quick fix.
>
Re: Spotless broken on master
Posted by Ismaël Mejía <ie...@gmail.com>.
Mmm this is weird, I tested this locally and passed without issue, I
am wondering how could this happen.
Thanks anyway for the quick fix.