You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/09 02:51:19 UTC
[GitHub] [spark] LuciferYang commented on a diff in pull request #36467: [SPARK-39063][CORE] Fix potential risk of JVM crash and `RocksDBIterator` resource leak
LuciferYang commented on code in PR #36467:
URL: https://github.com/apache/spark/pull/36467#discussion_r867596466
##########
common/kvstore/src/main/java/org/apache/spark/util/kvstore/RocksDB.java:
##########
@@ -457,4 +480,19 @@ byte[] getPrefix(RocksDBTypeInfo.Index idx) throws Exception {
}
+ private static class RocksDBIteratorWeakReference extends WeakReference<RocksDBIterator<?>> {
Review Comment:
`RocksDBIteratorWeakReference` use to hold `RocksIterator`, better as the inner class of `RocksDB` or `RocksDBIterator`? I want your suggestion @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org