You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/06/03 21:02:16 UTC

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

codecov-io edited a comment on issue #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct
URL: https://github.com/apache/incubator-pinot/pull/4216#issuecomment-493376612
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=h1) Report
   > Merging [#4216](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/00c22042dcaee666b04c91e766246919b7571fd1?src=pr&el=desc) will **decrease** coverage by `1.97%`.
   > The diff coverage is `32.1%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4216/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4216      +/-   ##
   ============================================
   - Coverage      67.3%   65.32%   -1.98%     
     Complexity       20       20              
   ============================================
     Files          1039     1049      +10     
     Lines         51535    54706    +3171     
     Branches       7228     7819     +591     
   ============================================
   + Hits          34685    35737    +1052     
   - Misses        14476    16372    +1896     
   - Partials       2374     2597     +223
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/pinot/pql/parsers/pql2/ast/PredicateAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9QcmVkaWNhdGVBc3ROb2RlLmphdmE=) | `50% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...che/pinot/common/request/HavingFilterQueryMap.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9IYXZpbmdGaWx0ZXJRdWVyeU1hcC5qYXZh) | `15% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...rg/apache/pinot/common/request/FilterQueryMap.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9GaWx0ZXJRdWVyeU1hcC5qYXZh) | `43.5% <ø> (+2%)` | `0 <0> (ø)` | :arrow_down: |
   | [...a/org/apache/pinot/common/request/QuerySource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9RdWVyeVNvdXJjZS5qYXZh) | `37.57% <ø> (+1.81%)` | `0 <0> (ø)` | :arrow_down: |
   | [...rg/apache/pinot/common/request/FilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9GaWx0ZXJPcGVyYXRvci5qYXZh) | `91.3% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...t/pql/parsers/pql2/ast/BooleanOperatorAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9Cb29sZWFuT3BlcmF0b3JBc3ROb2RlLmphdmE=) | `27.77% <0%> (-3.48%)` | `0 <0> (ø)` | |
   | [...che/pinot/common/response/ProcessingException.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzcG9uc2UvUHJvY2Vzc2luZ0V4Y2VwdGlvbi5qYXZh) | `24.89% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/apache/pinot/common/request/AggregationInfo.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9BZ2dyZWdhdGlvbkluZm8uamF2YQ==) | `35.42% <0%> (+2.5%)` | `0 <0> (ø)` | :arrow_down: |
   | [...apache/pinot/common/request/HavingFilterQuery.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9IYXZpbmdGaWx0ZXJRdWVyeS5qYXZh) | `12.2% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...a/org/apache/pinot/common/request/FilterQuery.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9GaWx0ZXJRdWVyeS5qYXZh) | `34.62% <0%> (+2.58%)` | `0 <0> (ø)` | :arrow_down: |
   | ... and [82 more](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=footer). Last update [00c2204...52ba2fc](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org