[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #3942: Set processingException when all queried segments cannot be acquired

[GitBox <gi...@apache.org>]

sunithabeeram commented on a change in pull request #3942: Set processingException when all queried segments cannot be acquired
URL: https://github.com/apache/incubator-pinot/pull/3942#discussion_r265735249
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/InstanceDataManager.java
 ##########
 @@ -78,6 +78,13 @@ void addRealtimeSegment(@Nonnull String realtimeTableName, @Nonnull String segme
   void removeSegment(@Nonnull String tableNameWithType, @Nonnull String segmentName)
       throws Exception;
 
+  /**
+   * Handles deletion of a segment from the table.
+   *
+   * This method performs book keeping of deleted segments.
+   */
+  void deleteSegment(@Nonnull String tableNameWithType, @Nonnull String segmentName);
 
 Review comment:
   Will change the method name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org