You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2023/04/05 00:52:18 UTC
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19691
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
IMPALA-12041: Select first executor group if query not auto-scalable
In multiple executor groups setup, some trivial query like "select 1;"
fail admission with "No mapping found for request" error message. This
patch fix a bug where we Frontend does not set group name prefix when
query is not auto-scalable. In cases like trivial query run, correct
executor group name prefix is still needed for backend to correctly
resolve the target pool.
Testing:
- Pass test_executor_groups.py
Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/custom_cluster/test_executor_groups.py
2 files changed, 65 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/19691/1
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
IMPALA-12041: Select first executor group if query not auto-scalable
In multiple executor groups setup, some trivial queries like "select 1;"
fail admission with "No mapping found for request" error message. This
patch fixes a bug where the Frontend does not set group name prefix when
query is not auto-scalable. In cases like trivial query run, correct
executor group name prefix is still needed for backend to correctly
resolve the target pool.
Testing:
- Pass test_executor_groups.py
Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Reviewed-on: http://gerrit.cloudera.org:8080/19691
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/custom_cluster/test_executor_groups.py
2 files changed, 67 insertions(+), 25 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19691/3/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:
http://gerrit.cloudera.org:8080/#/c/19691/3/tests/custom_cluster/test_executor_groups.py@940
PS3, Line 940: SELECT 1
seems all the "queryOptions.num_nodes == 1" would be handled as not auto-scalable not only trivial queries, not familiar with the auto-scalable, just a question that does this patch resume the behavior for "num_nodes == 1" cases to assign them to the first group?
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 17:31:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 3:
> Patch Set 3: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9201/
Hit flaky test TestTpcdsQueryWithProcessingCost.test_tpcds_q67a in dockerised env. I will try to rerun GVO again.
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 02:37:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9201/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 16:47:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Kurt Deschler, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19691
to look at the new patch set (#2).
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
IMPALA-12041: Select first executor group if query not auto-scalable
In multiple executor groups setup, some trivial queries like "select 1;"
fail admission with "No mapping found for request" error message. This
patch fixes a bug where the Frontend does not set group name prefix when
query is not auto-scalable. In cases like trivial query run, correct
executor group name prefix is still needed for backend to correctly
resolve the target pool.
Testing:
- Pass test_executor_groups.py
Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/custom_cluster/test_executor_groups.py
2 files changed, 65 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/19691/2
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 07:51:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 1:
(1 comment)
Will rebase this after IMPALA-12036 merged.
http://gerrit.cloudera.org:8080/#/c/19691/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19691/1//COMMIT_MSG@11
PS1, Line 11: we
nit: the
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 01:42:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 3: Code-Review+1
It makes sense to me. Ran the tests on local machine with PS3 and verified the issue was fixed.
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 16:46:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/19691/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19691/1//COMMIT_MSG@9
PS1, Line 9: queri
> Nit: queries?
Done
http://gerrit.cloudera.org:8080/#/c/19691/1//COMMIT_MSG@11
PS1, Line 11: e
> nit: the
Done
http://gerrit.cloudera.org:8080/#/c/19691/1//COMMIT_MSG@11
PS1, Line 11: fix
> Nit: fixes
Done
http://gerrit.cloudera.org:8080/#/c/19691/1/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:
http://gerrit.cloudera.org:8080/#/c/19691/1/tests/custom_cluster/test_executor_groups.py@914
PS1, Line 914: self.execute_query_expect_success(self.client, "SET ENABLE_REPLAN='';")
> Shouldn't we re-enable ENABLE_REPLAN after this query so this config doesn'
This is unsetting ENABLE_REPLAN option, which has default value True. So subsequent testcases after this will have ENABLE_REPLAN=true, just like the testcases before this.
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 12:39:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19691/3/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:
http://gerrit.cloudera.org:8080/#/c/19691/3/tests/custom_cluster/test_executor_groups.py@940
PS3, Line 940: SELECT 1
> seems all the "queryOptions.num_nodes == 1" would be handled as not auto-sc
Yes, setting NUM_NODES=1 option will let the query run in coordinator only, just like trivial queries.
https://impala.apache.org/docs/build/html/topics/impala_num_nodes.html
Tested manually and confirmed that it overrides the group set selection and correctly assign to the smallest group set. I can add this test case as a separate patch.
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 18:14:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19691/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19691/1//COMMIT_MSG@9
PS1, Line 9: query
Nit: queries?
http://gerrit.cloudera.org:8080/#/c/19691/1//COMMIT_MSG@11
PS1, Line 11: fix
Nit: fixes
http://gerrit.cloudera.org:8080/#/c/19691/1/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:
http://gerrit.cloudera.org:8080/#/c/19691/1/tests/custom_cluster/test_executor_groups.py@914
PS1, Line 914: self.execute_query_expect_success(self.client, "SET ENABLE_REPLAN='';")
Shouldn't we re-enable ENABLE_REPLAN after this query so this config doesn't affect the following queries?
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 08:07:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19691/1/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:
http://gerrit.cloudera.org:8080/#/c/19691/1/tests/custom_cluster/test_executor_groups.py@914
PS1, Line 914: self.execute_query_expect_success(self.client, "SET ENABLE_REPLAN='';")
> This is unsetting ENABLE_REPLAN option, which has default value True. So su
Thanks, I missed that line.
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 12:50:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 14:57:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12751/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 01:08:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 3: Code-Review+2
carry +2 from Kurt
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 16:46:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 16:43:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9203/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 02:38:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 02:38:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Kurt Deschler, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19691
to look at the new patch set (#3).
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
IMPALA-12041: Select first executor group if query not auto-scalable
In multiple executor groups setup, some trivial queries like "select 1;"
fail admission with "No mapping found for request" error message. This
patch fixes a bug where the Frontend does not set group name prefix when
query is not auto-scalable. In cases like trivial query run, correct
executor group name prefix is still needed for backend to correctly
resolve the target pool.
Testing:
- Pass test_executor_groups.py
Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/custom_cluster/test_executor_groups.py
2 files changed, 67 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/19691/3
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12753/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 16:49:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 01:05:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12041: Select first executor group if query not auto-scalable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9201/
--
To view, visit http://gerrit.cloudera.org:8080/19691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0
Gerrit-Change-Number: 19691
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 22:05:36 +0000
Gerrit-HasComments: No