You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/06 17:02:43 UTC

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #5991: [IR] Fix a primitive check error

MarisaKirisame commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-tvm/pull/5991#discussion_r449781641



##########
File path: include/tvm/ir/op.h
##########
@@ -146,6 +146,7 @@ class OpNode : public RelayExprNode {
   // Internal function to compute if it is primitive op
   bool IsPrimitiveOp_() const {
     const auto& fn_ty = this->op_type;
+    if (fn_ty.get() == 0) return false;

Review comment:
       ```suggestion
       if (fn_ty.get() == nullptr) return false;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org