You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/23 15:06:02 UTC

[GitHub] [flink] GJL commented on a change in pull request #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

GJL commented on a change in pull request #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/10934#discussion_r370171210
 
 

 ##########
 File path: docs/dev/stream/state/state.md
 ##########
 @@ -471,15 +471,12 @@ e.g. after restart from savepoint.
 
 ##### Cleanup during RocksDB compaction
 
-If RocksDB state backend is used, another cleanup strategy is to activate Flink specific compaction filter.
+If RocksDB state backend is used, another cleanup strategy is to call Flink specific compaction filter.
 
 Review comment:
   Currently it sounds like that the cleanup strategy won't be active by default or there are other strategies that can be used – Maybe that's just me. My proposal would be:
   
   > If the RocksDB state backend is used, a Flink specific compaction filter will be employed to enable background cleanup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services