You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/18 17:38:45 UTC

[GitHub] [spark] somani opened a new pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

somani opened a new pull request #34317:
URL: https://github.com/apache/spark/pull/34317


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   Column case was lost when we did an alter view because we would not save schema information in table properties for datasource tables when doing an alter view.
   The fix proposed is to save the required properties in table props in the alter codepath
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   This is a bug as schema case information is lost. Repro
   
   ```
   scala> sql("create view v as select 1 as A, 1 as B")
   res2: org.apache.spark.sql.DataFrame = []
   
   scala> sql("describe v").collect.foreach(println)
   [A,int,null]
   [B,int,null]
   
   scala> sql("alter view v as select 1 as C, 1 as D")
   res4: org.apache.spark.sql.DataFrame = []
   
   scala> sql("describe v").collect.foreach(println)
   [c,int,null]
   [d,int,null]
   ```
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   Yes. Now on an alter view, user will see column case preserved.
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Added unit tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946381468


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48861/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946901634


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144412/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] somani commented on a change in pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
somani commented on a change in pull request #34317:
URL: https://github.com/apache/spark/pull/34317#discussion_r731895061



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -3025,4 +3025,49 @@ class HiveDDLSuite
       assert(errMsg2.contains("Cannot use interval type in the table schema"))
     }
   }
+
+  test("SPARK-37046: Alter view should preserve column case with view definition change") {
+    withView("v") {
+      // Changing view definition should preserve column case
+      spark.sql("CREATE VIEW v AS SELECT 1 AS A, 1 AS B")
+      val df = spark.table("v")
+      assert("A".equals(df.schema.fields(0).name))
+      assert("B".equals(df.schema.fields(1).name))

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946376019


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48861/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan closed pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34317:
URL: https://github.com/apache/spark/pull/34317


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946359811


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48861/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34317:
URL: https://github.com/apache/spark/pull/34317#discussion_r731463426



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -3025,4 +3025,49 @@ class HiveDDLSuite
       assert(errMsg2.contains("Cannot use interval type in the table schema"))
     }
   }
+
+  test("SPARK-37046: Alter view should preserve column case with view definition change") {
+    withView("v") {
+      // Changing view definition should preserve column case
+      spark.sql("CREATE VIEW v AS SELECT 1 AS A, 1 AS B")
+      val df = spark.table("v")
+      assert("A".equals(df.schema.fields(0).name))
+      assert("B".equals(df.schema.fields(1).name))

Review comment:
       nit: `assert(df.schema.names == Seq("A", "B"))`

##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -3025,4 +3025,49 @@ class HiveDDLSuite
       assert(errMsg2.contains("Cannot use interval type in the table schema"))
     }
   }
+
+  test("SPARK-37046: Alter view should preserve column case with view definition change") {
+    withView("v") {
+      // Changing view definition should preserve column case
+      spark.sql("CREATE VIEW v AS SELECT 1 AS A, 1 AS B")
+      val df = spark.table("v")
+      assert("A".equals(df.schema.fields(0).name))
+      assert("B".equals(df.schema.fields(1).name))

Review comment:
       same to other places




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946749537


   **[Test build #144412 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144412/testReport)** for PR 34317 at commit [`4716953`](https://github.com/apache/spark/commit/4716953b07376066d079311d77c3837b94ac8d09).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946836073


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48886/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946340200


   **[Test build #144387 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144387/testReport)** for PR 34317 at commit [`94605f2`](https://github.com/apache/spark/commit/94605f2f8576c997b9bed0191cffcca57991539d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946006286


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] somani commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
somani commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946006648


   cc @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946340200


   **[Test build #144387 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144387/testReport)** for PR 34317 at commit [`94605f2`](https://github.com/apache/spark/commit/94605f2f8576c997b9bed0191cffcca57991539d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946006286


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946793676


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48886/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946749537


   **[Test build #144412 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144412/testReport)** for PR 34317 at commit [`4716953`](https://github.com/apache/spark/commit/4716953b07376066d079311d77c3837b94ac8d09).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946401854


   **[Test build #144387 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144387/testReport)** for PR 34317 at commit [`94605f2`](https://github.com/apache/spark/commit/94605f2f8576c997b9bed0191cffcca57991539d).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946408463


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144387/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946867002


   **[Test build #144412 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144412/testReport)** for PR 34317 at commit [`4716953`](https://github.com/apache/spark/commit/4716953b07376066d079311d77c3837b94ac8d09).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946333282


   ok to test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946848076


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48886/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-947453886


   thanks, merging to master/3.2!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-947582424


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946901634


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144412/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946848076


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48886/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946381468


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48861/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34317: [SPARK-37046][SQL]: Alter view does not preserve column case

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34317:
URL: https://github.com/apache/spark/pull/34317#issuecomment-946408463


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144387/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org