You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Vijay (Created) (JIRA)" <ji...@apache.org> on 2011/10/18 00:03:10 UTC
[jira] [Created] (CASSANDRA-3372) Make HSHA cached threads.
Make HSHA cached threads.
-------------------------
Key: CASSANDRA-3372
URL: https://issues.apache.org/jira/browse/CASSANDRA-3372
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 0.8.8, 1.0.1
Reporter: Vijay
Assignee: Vijay
JDK's newCachedTP does the following.... This is simillar to ACD.CleaningThreadPool
public static ExecutorService newCachedThreadPool(ThreadFactory threadFactory) {
return new ThreadPoolExecutor(0, Integer.MAX_VALUE,
60L, TimeUnit.SECONDS,
new SynchronousQueue<Runnable>(),
threadFactory);
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3372) Make HSHA cached threads.
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3372:
--------------------------------------
Reviewer: tjake
Priority: Minor (was: Major)
Affects Version/s: (was: 0.8.8)
(was: 1.0.1)
0.8.3
Fix Version/s: 1.0.1
Labels: thrift (was: )
> Make HSHA cached threads.
> -------------------------
>
> Key: CASSANDRA-3372
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3372
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8.3
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Labels: thrift
> Fix For: 1.0.1
>
> Attachments: 0001-update-to-cache-the-threads-for-tpe.patch
>
>
> JDK's newCachedTP does the following.... This is simillar to ACD.CleaningThreadPool
> public static ExecutorService newCachedThreadPool(ThreadFactory threadFactory) {
> return new ThreadPoolExecutor(0, Integer.MAX_VALUE,
> 60L, TimeUnit.SECONDS,
> new SynchronousQueue<Runnable>(),
> threadFactory);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3372) Make HSHA cached threads.
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-3372:
-----------------------------
Attachment: 0001-update-to-cache-the-threads-for-tpe.patch
I see a slight improvement with this setting.
> Make HSHA cached threads.
> -------------------------
>
> Key: CASSANDRA-3372
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3372
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8.8, 1.0.1
> Reporter: Vijay
> Assignee: Vijay
> Attachments: 0001-update-to-cache-the-threads-for-tpe.patch
>
>
> JDK's newCachedTP does the following.... This is simillar to ACD.CleaningThreadPool
> public static ExecutorService newCachedThreadPool(ThreadFactory threadFactory) {
> return new ThreadPoolExecutor(0, Integer.MAX_VALUE,
> 60L, TimeUnit.SECONDS,
> new SynchronousQueue<Runnable>(),
> threadFactory);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3372) Make HSHA cached threads.
Posted by "T Jake Luciani (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132887#comment-13132887 ]
T Jake Luciani commented on CASSANDRA-3372:
-------------------------------------------
+1
> Make HSHA cached threads.
> -------------------------
>
> Key: CASSANDRA-3372
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3372
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8.3
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Labels: thrift
> Fix For: 1.0.1
>
> Attachments: 0001-update-to-cache-the-threads-for-tpe.patch
>
>
> JDK's newCachedTP does the following.... This is simillar to ACD.CleaningThreadPool
> public static ExecutorService newCachedThreadPool(ThreadFactory threadFactory) {
> return new ThreadPoolExecutor(0, Integer.MAX_VALUE,
> 60L, TimeUnit.SECONDS,
> new SynchronousQueue<Runnable>(),
> threadFactory);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3372) Make HSHA cached threads.
Posted by "T Jake Luciani (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132841#comment-13132841 ]
T Jake Luciani commented on CASSANDRA-3372:
-------------------------------------------
Why 60 Seconds I wonder?
Can you quantify the improvement %?
> Make HSHA cached threads.
> -------------------------
>
> Key: CASSANDRA-3372
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3372
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8.3
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Labels: thrift
> Fix For: 1.0.1
>
> Attachments: 0001-update-to-cache-the-threads-for-tpe.patch
>
>
> JDK's newCachedTP does the following.... This is simillar to ACD.CleaningThreadPool
> public static ExecutorService newCachedThreadPool(ThreadFactory threadFactory) {
> return new ThreadPoolExecutor(0, Integer.MAX_VALUE,
> 60L, TimeUnit.SECONDS,
> new SynchronousQueue<Runnable>(),
> threadFactory);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3372) Make HSHA cached threads.
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132856#comment-13132856 ]
Vijay commented on CASSANDRA-3372:
----------------------------------
60 Seconds was inspired from the JDK implementation, we had 10 seconds earlier. I see around 1-2% increase in my tests.
> Make HSHA cached threads.
> -------------------------
>
> Key: CASSANDRA-3372
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3372
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8.3
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Labels: thrift
> Fix For: 1.0.1
>
> Attachments: 0001-update-to-cache-the-threads-for-tpe.patch
>
>
> JDK's newCachedTP does the following.... This is simillar to ACD.CleaningThreadPool
> public static ExecutorService newCachedThreadPool(ThreadFactory threadFactory) {
> return new ThreadPoolExecutor(0, Integer.MAX_VALUE,
> 60L, TimeUnit.SECONDS,
> new SynchronousQueue<Runnable>(),
> threadFactory);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira