You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/01/05 23:54:58 UTC
[jira] [Commented] (CB-12261) subdirectories deprecated warning
always shows and stop fetch
[ https://issues.apache.org/jira/browse/CB-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802915#comment-15802915 ]
ASF subversion and git services commented on CB-12261:
------------------------------------------------------
Commit 4191fa9b25b06140c58037ab9b504d6c9b9b064d in cordova-lib's branch refs/heads/master from [~yyfearth@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=4191fa9 ]
CB-12261: fix subdirectories deprecated warning always shows and stop fetch caused by CB-11979
This closes #511
> subdirectories deprecated warning always shows and stop fetch
> -------------------------------------------------------------
>
> Key: CB-12261
> URL: https://issues.apache.org/jira/browse/CB-12261
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Environment: Any
> Reporter: Wilson Yang
> Priority: Critical
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> CB-11979 introduced a warning for using subdir with git url.
> But even there is no subdir, it still show the warning, or prevent fetch.
> Because the line of code `options.subdir = options.subdir || '.';`
> And `if (result[2]) options.subdir = result[2];` will not set subdir to empty
> Then `if(options.subdir) {` will always true since options.subdir is '.' by default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org