You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucenenet.apache.org by pa...@apache.org on 2026/06/22 14:56:41 UTC

(lucenenet-codeanalysis-dev) branch main updated: Revise diagnostic ID reservation process in README (#35)

This is an automated email from the ASF dual-hosted git repository.

paulirwin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/lucenenet-codeanalysis-dev.git


The following commit(s) were added to refs/heads/main by this push:
     new 0ea9228  Revise diagnostic ID reservation process in README (#35)
0ea9228 is described below

commit 0ea9228f67547b7d1dac13155c73dbcb287aaa24
Author: Paul Irwin <pa...@gmail.com>
AuthorDate: Mon Jun 22 08:56:37 2026 -0600

    Revise diagnostic ID reservation process in README (#35)
    
    Updated instructions for reserving diagnostic IDs due to ASF Infra branch protection of `main`.
---
 README.md | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 18002cd..4951d07 100644
--- a/README.md
+++ b/README.md
@@ -63,9 +63,8 @@ It is important that you follow this process to avoid rework of your PR.
 
 1. Make sure there is an issue on the main [Apache Lucene.NET repo](https://github.com/apache/lucenenet/issues) for the analyzer(s) needed, that has been approved by the Lucene.NET team as indicated by having the `approved-rule` label.
 2. Reserve your diagnostic ID(s) _before_ implementing the analyzer(s):
-    - If you are a Lucene.NET committer, you can reserve one yourself. Modify the [DiagnosticCategoryAndIdRanges.txt](DiagnosticCategoryAndIdRanges.txt) file (following the instructions in that file) to reserve your ID(s). Commit and push the change to this file directly to the `main` branch, as the only file in the commit. DO NOT include any other code or changes in this commit. In the event of a conflict, do not merge this file; discard your changes, pull latest, and try again. Include [...]
-    - If you are not a Lucene.NET committer, request in the discussion for the GitHub issue that a committer do the steps above for you for your desired number of diagnostic IDs. Please make sure to mention which category the ID(s) should belong to.
-3. Once you have the reserved ID(s), you can proceed with implementing your analyzer and submitting a pull request. Make sure to include your analyzer in the [AnalyzerReleases.Unshipped.md](src/Lucene.Net.CodeAnalysis.Dev/AnalyzerReleases.Unshipped.md) file.
+    - Submit a pull request that modifies the [DiagnosticCategoryAndIdRanges.txt](DiagnosticCategoryAndIdRanges.txt) file (following the instructions in that file) to reserve your ID(s). Make sure your PR is based on latest `main`, and that the correct category is chosen for each ID. DO NOT include any other code or changes in this commit. In the event of a conflict, this PR cannot be merged; pull latest, and try again (possibly with new IDs chosen). Include the issue number in your comm [...]
+3. Once you have the reserved ID(s) merged on `main`, you can proceed with implementing your analyzer and submitting a pull request. Make sure to include your analyzer in the [AnalyzerReleases.Unshipped.md](src/Lucene.Net.CodeAnalysis.Dev/AnalyzerReleases.Unshipped.md) file.
 
 ### Requirements