[GitHub] [parquet-format] wgtmac commented on a diff in pull request #194: PARQUET-2257: Add bloom_filter_length to ColumnMetaData

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #194:
URL: https://github.com/apache/parquet-format/pull/194#discussion_r1158000250


##########
src/main/thrift/parquet.thrift:
##########
@@ -753,6 +753,9 @@ struct ColumnMetaData {
 
   /** Byte offset from beginning of file to Bloom filter data. **/
   14: optional i64 bloom_filter_offset;
+
+  /** Size of Bloom filter data, in bytes. **/
+  15: optional i32 bloom_filter_length;

Review Comment:
   Agreed.
   
   I have thought to add a comment to say that `bloom_filter_length` is introduced by v2.10.0 (the next unreleased version) and readers may not expect its existence from legacy files or some implementations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org