You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "roeap (via GitHub)" <gi...@apache.org> on 2025/08/29 20:31:06 UTC

[PR] feat: add LITE keyword [datafusion-sqlparser-rs]

roeap opened a new pull request, #2018:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2018

   The LITE keyword is used in the delta [VACUUM](https://docs.databricks.com/aws/en/sql/language-manual/delta-vacuum) command, would be great if we could add it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat: add some DELTA keywords [datafusion-sqlparser-rs]

Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on code in PR #2018:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2018#discussion_r2315618662


##########
src/keywords.rs:
##########
@@ -491,6 +491,7 @@ define_keywords!(
     INTERSECTION,
     INTERVAL,
     INTO,
+    INVENTORY,

Review Comment:
   We can probably extend[ this test ](https://github.com/apache/datafusion-sqlparser-rs/blob/main/tests/sqlparser_redshift.rs#L412)to include new scenarios?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat: add some DELTA keywords [datafusion-sqlparser-rs]

Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on code in PR #2018:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2018#discussion_r2321586942


##########
src/keywords.rs:
##########
@@ -491,6 +491,7 @@ define_keywords!(
     INTERSECTION,
     INTERVAL,
     INTO,
+    INVENTORY,

Review Comment:
   Ah yeah it should possible to support databricks' variant of the vacuum command. But we tend to not have dialect specific statements so that it'll likely need to be part of the existing `Statement::Vacuum` variant in this case, being extended to support the new options



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat: add some DELTA keywords [datafusion-sqlparser-rs]

Posted by "roeap (via GitHub)" <gi...@apache.org>.
roeap commented on code in PR #2018:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2018#discussion_r2311851704


##########
src/keywords.rs:
##########
@@ -491,6 +491,7 @@ define_keywords!(
     INTERSECTION,
     INTERVAL,
     INTO,
+    INVENTORY,

Review Comment:
   Certainly @iffyio. I had been looking through the code for existing tests, but to no avail. So unsure if I should add some cases to the tokenizer tests or in the parser module?
   
   Or is there a more obvious place I am missing?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat: add some DELTA keywords [datafusion-sqlparser-rs]

Posted by "roeap (via GitHub)" <gi...@apache.org>.
roeap commented on code in PR #2018:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2018#discussion_r2318492300


##########
src/keywords.rs:
##########
@@ -491,6 +491,7 @@ define_keywords!(
     INTERSECTION,
     INTERVAL,
     INTO,
+    INVENTORY,

Review Comment:
   @iffyio - your hint got me to dive a bit deeper into the codebase. Unfortunately the Redhsift and Databricks VACUUM commands are quite different.
   
   That said, would you accept a PR where I extend this a bit, add a custom statement parser option the databricks dialect and a `VacuumDatabricks` Statement variant?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat: add some DELTA keywords [datafusion-sqlparser-rs]

Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on code in PR #2018:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2018#discussion_r2311820084


##########
src/keywords.rs:
##########
@@ -491,6 +491,7 @@ define_keywords!(
     INTERSECTION,
     INTERVAL,
     INTO,
+    INVENTORY,

Review Comment:
   Can we add test cases to demonstrate the added functionality?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat: add some DELTA keywords [datafusion-sqlparser-rs]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2018: feat: add some DELTA keywords
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2018


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] feat: add some DELTA keywords [datafusion-sqlparser-rs]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2018:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2018#issuecomment-3483420928

   Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org