You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by mh...@apache.org on 2019/05/29 16:37:07 UTC

[asterixdb] branch master updated: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config

This is an automated email from the ASF dual-hosted git repository.

mhubail pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 7e42e62  [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
7e42e62 is described below

commit 7e42e6285cb4b605dc4d00c98604586b36d756ac
Author: Murtadha Hubail <mh...@apache.org>
AuthorDate: Tue May 28 05:29:36 2019 +0300

    [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details:
    - Mark KeyStore pass as a hidden config to avoid
      displaying the password on APIs that use the hidden
      flag to certain config.
    
    Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/3413
    Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Reviewed-by: Ali Alsuliman <al...@gmail.com>
---
 .../java/org/apache/hyracks/control/common/controllers/CCConfig.java | 5 +++++
 .../java/org/apache/hyracks/control/common/controllers/NCConfig.java | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
index a38ee65..4f35aca 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
@@ -211,6 +211,11 @@ public class CCConfig extends ControllerConfig {
         public String usageDefaultOverride(IApplicationConfig accessor, Function<IOption, String> optionPrinter) {
             return defaultValueDescription;
         }
+
+        @Override
+        public boolean hidden() {
+            return this == KEY_STORE_PASSWORD;
+        }
     }
 
     private List<String> appArgs = new ArrayList<>();
diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
index dd92798..e947d7a 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
@@ -247,6 +247,10 @@ public class NCConfig extends ControllerConfig {
             return defaultValueDescription;
         }
 
+        @Override
+        public boolean hidden() {
+            return this == KEY_STORE_PASSWORD;
+        }
     }
 
     public String getReplicationPublicAddress() {