You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/12 19:27:04 UTC
[GitHub] vanzin commented on a change in pull request #23686:
[SPARK-26772][YARN] YARNHadoopDelegationTokenManager loads
ServiceCredentialProviders independently
vanzin commented on a change in pull request #23686: [SPARK-26772][YARN] YARNHadoopDelegationTokenManager loads ServiceCredentialProviders independently
URL: https://github.com/apache/spark/pull/23686#discussion_r256110518
##########
File path: core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenProvider.scala
##########
@@ -18,15 +18,16 @@
package org.apache.spark.deploy.security
import org.apache.hadoop.conf.Configuration
-import org.apache.hadoop.fs.FileSystem
import org.apache.hadoop.security.Credentials
import org.apache.spark.SparkConf
+import org.apache.spark.annotation.DeveloperApi
/**
* Hadoop delegation token provider.
*/
-private[spark] trait HadoopDelegationTokenProvider {
+@DeveloperApi
Review comment:
You need to update the doc comment (see javadoc for `DeveloperApi`), because scaladoc is weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org