You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Andrew Purtell <ap...@apache.org> on 2010/08/03 10:41:36 UTC
Review Request: [REST] RowResultGenerator should handle
NoSuchColumnFamilyException
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/482/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
RowResultGenerator should handle NoSuchColumnFamilyException. Otherwise the client gets an ugly exception and Jersey is left in an incorrect state.
This addresses bug HBASE-2897.
http://issues.apache.org/jira/browse/HBASE-2897
Diffs
-----
src/main/java/org/apache/hadoop/hbase/rest/RowResultGenerator.java b742ded
src/main/java/org/apache/hadoop/hbase/rest/client/Client.java 45cf2db
src/test/java/org/apache/hadoop/hbase/rest/TestRowResource.java 392505e
Diff: http://review.cloudera.org/r/482/diff
Testing
-------
Added unit test. Confirmed bug as reported. Fixed bug. New unit test now passes. No regressions observed running the unit test suite locally.
Thanks,
Andrew
Re: Review Request: [REST] RowResultGenerator should handle
NoSuchColumnFamilyException
Posted by st...@duboce.net.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/482/#review629
-----------------------------------------------------------
Ship it!
+1 Looks good to me.
- stack
On 2010-08-03 01:41:36, Andrew Purtell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/482/
> -----------------------------------------------------------
>
> (Updated 2010-08-03 01:41:36)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> RowResultGenerator should handle NoSuchColumnFamilyException. Otherwise the client gets an ugly exception and Jersey is left in an incorrect state.
>
>
> This addresses bug HBASE-2897.
> http://issues.apache.org/jira/browse/HBASE-2897
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/rest/RowResultGenerator.java b742ded
> src/main/java/org/apache/hadoop/hbase/rest/client/Client.java 45cf2db
> src/test/java/org/apache/hadoop/hbase/rest/TestRowResource.java 392505e
>
> Diff: http://review.cloudera.org/r/482/diff
>
>
> Testing
> -------
>
> Added unit test. Confirmed bug as reported. Fixed bug. New unit test now passes. No regressions observed running the unit test suite locally.
>
>
> Thanks,
>
> Andrew
>
>