You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/06/28 21:23:50 UTC

[GitHub] [cordova] janpio opened a new issue #134: [Plugins] Distribute better .gitattributes file to all repos

janpio opened a new issue #134: [Plugins] Distribute better .gitattributes file to all repos
URL: https://github.com/apache/cordova/issues/134
 
 
   Seems a minimal `.gitattributes` might not be such a good idea:
   
   ```
   * text eol=lf
   ```
   
   This can also cause edits to clearly binary files, otherwise as expected git is not smart enough to know that `.png` for example should keep its line ending.
   
   This seems to be a better file:
   
   ```
   * text eol=lf
   
   #
   ## These files are binary and should be left untouched
   #
   
   # (binary is a macro for -text -diff)
   *.png binary
   *.jpg binary
   *.jpeg binary
   *.gif binary
   *.ico binary
   *.mov binary
   *.mp4 binary
   *.mp3 binary
   *.flv binary
   *.fla binary
   *.swf binary
   *.gz binary
   *.zip binary
   *.7z binary
   *.ttf binary
   *.eot binary
   *.woff binary
   *.pyc binary
   *.pdf binary
   ```
   
   Some projects even have a list of explicitly text files that should be touched, but I can't imagine that this is also necessary: https://github.com/apache/cordova-ios/blob/master/.gitattributes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org