You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/06/27 04:36:29 UTC

[jira] Created: (HARMONY-671) [classlib][nio] java.nio.channels.FileLock.overlaps() should return true when the lock range is a subset of the given one.

[classlib][nio] java.nio.channels.FileLock.overlaps()  should return true when the lock range is a subset of the given one.
---------------------------------------------------------------------------------------------------------------------------

         Key: HARMONY-671
         URL: http://issues.apache.org/jira/browse/HARMONY-671
     Project: Harmony
        Type: Bug

  Components: Classlib  
    Reporter: Andrew Zhang


java.nio.channels.FileLock.overlaps()  should return true when the lock range is a subset of the given one.

Following test reproduces the bug: 

public void test_overlaps_lock() throws IOException {
        FileLock flock = readWriteChannel.lock(5, 10, true);  
        assertTrue(flock.overlaps(2, 20));
}

RI 5.0 passes the test, but Harmony fails. 

I'll fix the problem soon. 

Thanks.

Best regards,
Andrew


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Resolved: (HARMONY-671) [classlib][nio] java.nio.channels.FileLock.overlaps() should return true when the lock range is a subset of the given one.

Posted by "George Harley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-671?page=all ]
     
George Harley resolved HARMONY-671:
-----------------------------------

    Resolution: Fixed

Hi Andrew, 

Good catch ! Patch committed in revision 417384. Please could you verify that it has been applied as expected. 

Thanks for this enhancement. 

Best regards,
George


> [classlib][nio] java.nio.channels.FileLock.overlaps()  should return true when the lock range is a subset of the given one.
> ---------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-671
>          URL: http://issues.apache.org/jira/browse/HARMONY-671
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>  Attachments: nio.diff
>
> java.nio.channels.FileLock.overlaps()  should return true when the lock range is a subset of the given one.
> Following test reproduces the bug: 
> public void test_overlaps_lock() throws IOException {
>         FileLock flock = readWriteChannel.lock(5, 10, true);  
>         assertTrue(flock.overlaps(2, 20));
> }
> RI 5.0 passes the test, but Harmony fails. 
> I'll fix the problem soon. 
> Thanks.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Assigned: (HARMONY-671) [classlib][nio] java.nio.channels.FileLock.overlaps() should return true when the lock range is a subset of the given one.

Posted by "George Harley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-671?page=all ]

George Harley reassigned HARMONY-671:
-------------------------------------

    Assign To: George Harley

> [classlib][nio] java.nio.channels.FileLock.overlaps()  should return true when the lock range is a subset of the given one.
> ---------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-671
>          URL: http://issues.apache.org/jira/browse/HARMONY-671
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>  Attachments: nio.diff
>
> java.nio.channels.FileLock.overlaps()  should return true when the lock range is a subset of the given one.
> Following test reproduces the bug: 
> public void test_overlaps_lock() throws IOException {
>         FileLock flock = readWriteChannel.lock(5, 10, true);  
>         assertTrue(flock.overlaps(2, 20));
> }
> RI 5.0 passes the test, but Harmony fails. 
> I'll fix the problem soon. 
> Thanks.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (HARMONY-671) [classlib][nio] java.nio.channels.FileLock.overlaps() should return true when the lock range is a subset of the given one.

Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-671?page=comments#action_12418006 ] 

Andrew Zhang commented on HARMONY-671:
--------------------------------------

Hello George,

The fix looks good, many thanks!


Best regards,
Andrew

> [classlib][nio] java.nio.channels.FileLock.overlaps()  should return true when the lock range is a subset of the given one.
> ---------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-671
>          URL: http://issues.apache.org/jira/browse/HARMONY-671
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>  Attachments: nio.diff
>
> java.nio.channels.FileLock.overlaps()  should return true when the lock range is a subset of the given one.
> Following test reproduces the bug: 
> public void test_overlaps_lock() throws IOException {
>         FileLock flock = readWriteChannel.lock(5, 10, true);  
>         assertTrue(flock.overlaps(2, 20));
> }
> RI 5.0 passes the test, but Harmony fails. 
> I'll fix the problem soon. 
> Thanks.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (HARMONY-671) [classlib][nio] java.nio.channels.FileLock.overlaps() should return true when the lock range is a subset of the given one.

Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-671?page=all ]

Andrew Zhang updated HARMONY-671:
---------------------------------

    Attachment: nio.diff

Hello,

Would you please try my patch?

Thanks!

Best regards,
Andrew

> [classlib][nio] java.nio.channels.FileLock.overlaps()  should return true when the lock range is a subset of the given one.
> ---------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-671
>          URL: http://issues.apache.org/jira/browse/HARMONY-671
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Andrew Zhang
>  Attachments: nio.diff
>
> java.nio.channels.FileLock.overlaps()  should return true when the lock range is a subset of the given one.
> Following test reproduces the bug: 
> public void test_overlaps_lock() throws IOException {
>         FileLock flock = readWriteChannel.lock(5, 10, true);  
>         assertTrue(flock.overlaps(2, 20));
> }
> RI 5.0 passes the test, but Harmony fails. 
> I'll fix the problem soon. 
> Thanks.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Closed: (HARMONY-671) [classlib][nio] java.nio.channels.FileLock.overlaps() should return true when the lock range is a subset of the given one.

Posted by "George Harley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-671?page=all ]
     
George Harley closed HARMONY-671:
---------------------------------


Verified by Andrew.

> [classlib][nio] java.nio.channels.FileLock.overlaps()  should return true when the lock range is a subset of the given one.
> ---------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-671
>          URL: http://issues.apache.org/jira/browse/HARMONY-671
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>  Attachments: nio.diff
>
> java.nio.channels.FileLock.overlaps()  should return true when the lock range is a subset of the given one.
> Following test reproduces the bug: 
> public void test_overlaps_lock() throws IOException {
>         FileLock flock = readWriteChannel.lock(5, 10, true);  
>         assertTrue(flock.overlaps(2, 20));
> }
> RI 5.0 passes the test, but Harmony fails. 
> I'll fix the problem soon. 
> Thanks.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira