You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "epiao55 (via GitHub)" <gi...@apache.org> on 2023/02/26 07:07:27 UTC
[GitHub] [incubator-eventmesh] epiao55 opened a new issue, #3273: [Bug] Incorrect validation may cause the batch send of events to fail
epiao55 opened a new issue, #3273:
URL: https://github.com/apache/incubator-eventmesh/issues/3273
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Environment
Windows
### EventMesh version
master
### What happened
path is `org/apache/eventmesh/runtime/core/protocol/http/processor/BatchSendMessageProcessor.java`
i think this is a bug when i read code of master branch. This will cause the batch send of events to fail.
```java
if (eventData != null || StringUtils.isBlank(batchId)
|| StringUtils.isBlank(producerGroup)
|| eventSize != eventList.size()) {
responseEventMeshCommand = asyncContext.getRequest().createHttpCommandResponse(
sendMessageBatchResponseHeader,
SendMessageBatchResponseBody.buildBody(EventMeshRetCode.EVENTMESH_PROTOCOL_BODY_ERR.getRetCode(),
EventMeshRetCode.EVENTMESH_PROTOCOL_BODY_ERR.getErrMsg()));
asyncContext.onComplete(responseEventMeshCommand);
return;
}
```
The validation of `eventData` should be changed to '==null'.
### How to reproduce
just read the code
### Debug logs
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #3273: [Bug] Incorrect validation may cause the batch send of events to fail
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 closed issue #3273: [Bug] Incorrect validation may cause the batch send of events to fail
URL: https://github.com/apache/incubator-eventmesh/issues/3273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org