You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2026/06/08 23:00:59 UTC
[Impala-ASF-CR] IMPALA-14782: (Addendum) Add roaringbitmap
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24420
Change subject: IMPALA-14782: (Addendum) Add roaringbitmap
......................................................................
IMPALA-14782: (Addendum) Add roaringbitmap
Merge can trigger BitmapPositionDeleteIndex.deserialize, which requires
RoaringBitmaps. This dependency was not included in the
impala-iceberg-runtime, leading to java.lang.NoClassDefFoundError:
org/roaringbitmap/RoaringBitmap in some cases.
Adds a test that frequently triggers this error in my environment.
Change-Id: I8468145944efee898a4b00758b1f4e5dedd9312d
---
M java/shaded-deps/impala-iceberg-runtime/pom.xml
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-merge.test
2 files changed, 31 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/24420/1
--
To view, visit http://gerrit.cloudera.org:8080/24420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8468145944efee898a4b00758b1f4e5dedd9312d
Gerrit-Change-Number: 24420
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-14782: (Addendum) Add roaringbitmap
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24420 )
Change subject: IMPALA-14782: (Addendum) Add roaringbitmap
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/24420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8468145944efee898a4b00758b1f4e5dedd9312d
Gerrit-Change-Number: 24420
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 07:53:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14782: (Addendum) Add roaringbitmap
Posted by "Mihaly Szjatinya (Code Review)" <ge...@cloudera.org>.
Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/24420 )
Change subject: IMPALA-14782: (Addendum) Add roaringbitmap
......................................................................
Patch Set 1:
I wasn't able to reproduce it with just the test provided.
@Zoltan, thanks for addressing this!
--
To view, visit http://gerrit.cloudera.org:8080/24420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8468145944efee898a4b00758b1f4e5dedd9312d
Gerrit-Change-Number: 24420
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 12:08:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14782: (Addendum) Add roaringbitmap
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24420 )
Change subject: IMPALA-14782: (Addendum) Add roaringbitmap
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22791/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8468145944efee898a4b00758b1f4e5dedd9312d
Gerrit-Change-Number: 24420
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2026 23:24:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14782: (Addendum) Add roaringbitmap
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24420 )
Change subject: IMPALA-14782: (Addendum) Add roaringbitmap
......................................................................
Patch Set 1:
Uploaded a different fix to: https://gerrit.cloudera.org/#/c/24425/
--
To view, visit http://gerrit.cloudera.org:8080/24420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8468145944efee898a4b00758b1f4e5dedd9312d
Gerrit-Change-Number: 24420
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 12:03:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14782: (Addendum) Add roaringbitmap
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24420 )
Change subject: IMPALA-14782: (Addendum) Add roaringbitmap
......................................................................
Patch Set 1:
I repro'ed the issue, looks like a bug in MERGE, it doesn't shuffle records the way it should. I'm trying to fix that bug. Adding RoaringBitmap as a dependency would just hide the problem.
--
To view, visit http://gerrit.cloudera.org:8080/24420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8468145944efee898a4b00758b1f4e5dedd9312d
Gerrit-Change-Number: 24420
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 09:06:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14782: (Addendum) Add roaringbitmap
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has abandoned this change. ( http://gerrit.cloudera.org:8080/24420 )
Change subject: IMPALA-14782: (Addendum) Add roaringbitmap
......................................................................
Abandoned
Not the right solution.
--
To view, visit http://gerrit.cloudera.org:8080/24420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I8468145944efee898a4b00758b1f4e5dedd9312d
Gerrit-Change-Number: 24420
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>