You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/05/03 05:05:32 UTC
[GitHub] [incubator-echarts] quillblue opened a new pull request #12556: Fix #12259
quillblue opened a new pull request #12556:
URL: https://github.com/apache/incubator-echarts/pull/12556
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [X] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Update function of calculating updated height & width for rotated axis labels
Fix issue #12259
### Fixed issues
Fix issue #12259
## Details
In previous `rotateTextRect()` in axisHelper.js, take cos value of negative rotate will got negative result, which causes calculated width/height of rotated axis label is smaller than actual size. In grid, it will cause axis labels be cut.
### After: How is it fixed in this PR?
As physically we need cos/sin of rotate angle to be positive (or 0), add Math.abs here to solve this issue,
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #12556: fix(axisLabel): fix axisLabel rotating with grid.containLabel #12259
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #12556:
URL: https://github.com/apache/incubator-echarts/pull/12556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12556: Fix #12259
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12556:
URL: https://github.com/apache/incubator-echarts/pull/12556#issuecomment-623054725
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] quillblue commented on pull request #12556: Fix #12259
Posted by GitBox <gi...@apache.org>.
quillblue commented on pull request #12556:
URL: https://github.com/apache/incubator-echarts/pull/12556#issuecomment-623085561
@susiwen8 Thanks for kind reminder. Revert changes in `dist ` back to previous version in new commit. Accordingly please squash to one during merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #12556: Fix #12259
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #12556:
URL: https://github.com/apache/incubator-echarts/pull/12556#issuecomment-623125022
@quillblue Could you add a test case for this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] quillblue commented on pull request #12556: Fix #12259
Posted by GitBox <gi...@apache.org>.
quillblue commented on pull request #12556:
URL: https://github.com/apache/incubator-echarts/pull/12556#issuecomment-623231631
@susiwen8 Sure. In latest commit I added a test case using same option as original issue [using](https://gallery.echartsjs.com/editor.html?c=xOcNMBdkE&v=1)
and below are before&after comparision
Before:
After:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12556: fix(axisLabel): fix axisLabel rotating with grid.containLabel #12259
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12556:
URL: https://github.com/apache/incubator-echarts/pull/12556#issuecomment-668387061
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] quillblue commented on pull request #12556: fix(axisLabel): fix axisLabel rotating with grid.containLabel #12259
Posted by GitBox <gi...@apache.org>.
quillblue commented on pull request #12556:
URL: https://github.com/apache/incubator-echarts/pull/12556#issuecomment-624502229
@Ovilia combined to `axisLabel.html` case 2 per your idea. The existing case has animation to show the rotate of labels, which has greater idea than my demo.
Though `rotate: 330` is same as `rotate: -30`, I set xAxis rotate from -180 to 180 (instead of 0-360) as users are more used to use negative value to represent clockwise rotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org