You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "borinquenkid (via GitHub)" <gi...@apache.org> on 2026/10/11 13:41:44 UTC

[PR] refactor: convert grails-converters to Groovy [grails-core]

borinquenkid opened a new pull request, #16601:
URL: https://github.com/apache/grails-core/pull/16601

   ## What
   
   Converts the remaining Java sources of `grails-converters` to Groovy: 60 `.java` files removed, 60 `.groovy` files added (72 files changed, 3729 insertions(+), 3647 deletions(-)).
   
   ## Why
   
   The maintainers asked on #16351 for the Java-to-Groovy migration to land one Gradle project at a time as a stack of PRs, bottom-up in dependency order. #16572 did `grails-data-hibernate7`; this PR is 19 of 30 in the next stack (base: `refactor/java-to-groovy-grails-web-common`). The end state of every file is taken from the `9.0.x-java-to-groovy` branch, which already carries the regression fixes found by CI.
   
   Commits:
   - 6df746b81d fix: keep the Java-facing API of the converted grails-converters classes
   - 3fa21fc6d6 refactor: convert grails-converters to Groovy
   
   ## Changed outside the converted sources
   
   - nothing
   
   ## Java-facing API sweep
   
   Every deleted `.java` was compared with its Groovy twin via `javap -v -protected` (class declaration, public/protected fields, constructors, methods incl. modifiers/throws/generics, interface default methods, nested class modifiers, and the annotations callers see). Result:
   
   - `grails-converters`: 60 deleted .java, 4 difference(s) found and fixed in this PR (see the `fix:` commit), 0 left
   
   See also the notes below. Remaining informational entries (widened visibility, e.g. Groovy property accessors): 10.
   
   ## Verification
   
   - `classes` and `testClasses` (plus `ast`/`cli`/`testFixtures` source sets where present) of the converted project(s) and of their direct dependents compile: ['grails-data-graphql', 'grails-rest-transforms', 'grails-spring-security', 'grails-spring-security-oauth2', 'grails-spring-security-rest', 'grails-spring-security-ui', 'grails-test-core', 'grails-test-suite-base']
   - No test suites were run locally (the umbrella branch was verified; CI runs them). `codeStyle`, `rat` and a whole-repo `build -PskipTests` are run once on the tip of the stack.
   
   ## Notes
   
   - Informational sweep entries that are not regressions: Groovy enums gain `MIN_VALUE`/`MAX_VALUE`/`next()`/`previous()`, property accessors appear for formerly package-private members, nested static classes with implicit constructors become public (they were `protected`), and generic type parameters that Groovy erases in constructors/methods (descriptors identical).
   - Groovy gotchas that applied (see #16351): `static final` without `public` creates a property; `==` calls `equals()`; Closure/SAM coercions; `@CompileStatic` with nested classes. All CI regression fixes found on the umbrella branch are included in the end state.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: convert grails-converters to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16601:
URL: https://github.com/apache/grails-core/pull/16601#issuecomment-6155224364

   ## ✅ All tests passed ✅
   
   🏷️ Commit: e0aa3b2bc4de81b5d9989a002828760229ba1ae1
   ▶️ Tests:  25 executed
   ⚪️ Checks: 30/30 completed
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: convert grails-converters to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16601:
URL: https://github.com/apache/grails-core/pull/16601#issuecomment-6109659980

   ## 🚨 All tests passed but jobs failed 🚨
   
   ### Failed Jobs without Test Failures
   
   ❌ [Build Health / Gradle Plugin Projects](https://github.com/apache/grails-core/actions/runs/38144199076/job/114484027303?pr=16601)
   
   🏷️ Commit: 6df746b81d9231b22ae502a0bee9dd70b5c995d2
   ▶️ Tests:  264 executed
   🟡 Checks: 5/75 completed
   
   ### Rerun Controls
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: convert grails-converters to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16601:
URL: https://github.com/apache/grails-core/pull/16601#issuecomment-6113186526

   ## 🚨 All tests passed but jobs failed 🚨
   
   ### Failed Jobs without Test Failures
   
   ❌ [CI / Redis Tests \(25, 8.0\)](https://github.com/apache/grails-core/actions/runs/38170636942/job/114562328655?pr=16601)
   
   🏷️ Commit: 0b2f6c59d6036c6cf41242e5c38d5670aa9f63b4
   ▶️ Tests:  416 executed
   🟡 Checks: 7/77 completed
   
   ### Rerun Controls
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: convert grails-converters to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16601:
URL: https://github.com/apache/grails-core/pull/16601#issuecomment-6160008157

   ## ✅ All tests passed ✅
   
   🏷️ Commit: 0ceee1c4539ebdba38b648e9af8441258a2093af
   ▶️ Tests:  82109 executed
   ⚪️ Checks: 83/83 completed
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: convert grails-converters to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16601:
URL: https://github.com/apache/grails-core/pull/16601#issuecomment-6207371800

   ## 🚨 TestLens detected 1 failed test 🚨
   
   ### Test Summary
   > [!TIP]
   > Inspect all details with the [TestLens CLI](https://testlens.app/docs/features/cli): `testlens pr 16601`
   
   #### [CI / Build Grails-Core \(Windows JDK 25 shard 0\)](https://github.com/apache/grails-core/actions/runs/38844118855/job/116790622133?pr=16601) > :grails-async-groovy-concurrent:test
   
   | Test | Runs | Flakiness |
   |---|---|--:|
   | AwaitablePromiseFactorySpec > single and aggregate error callbacks receive the same original failure > single and aggregate error callbacks receive the same original failure [checked: true, <span>#</span>1] | ❌ | 0%&nbsp;🟢 |
   
   🏷️ Commit: a8731325886b23f428c6bb914a6de7de52e468ef
   ▶️ Tests:  21135 executed
   🟡 Checks: 30/79 completed
   
   ### Test Failures
   
   <details><summary><strong>AwaitablePromiseFactorySpec > single and aggregate error callbacks receive the same original failure > single and aggregate error callbacks receive the same original failure [checked: true, <span>#</span>1]</strong> (:grails-async-groovy-concurrent:test in <a href="https://github.com/apache/grails-core/actions/runs/38844118855/job/116790622133?pr=16601">CI / Build Grails-Core (Windows JDK 25 shard 0)</a>)</summary>
   
   ```
   Condition not satisfied:
   
   single.is(original)
   |      |  |
   null   |  java.io.IOException: outer
          |  	at org.grails.async.factory.groovy.AwaitablePromiseFactorySpec.$spock_feature_0_21(AwaitablePromiseFactorySpec.groovy:346)
          false
   
   	at org.grails.async.factory.groovy.AwaitablePromiseFactorySpec.single and aggregate error callbacks receive the same original failure(AwaitablePromiseFactorySpec.groovy:361)
   ```
   
   </details>
   
   ### Rerun Controls
   > [!NOTE]
   > Checks are currently running using the configuration below.
   
   Select tests to mute in this pull request:
   
   🔲 AwaitablePromiseFactorySpec > single and aggregate error callbacks receive the same original failure <!-- uniqueId=[engine:spock]/[spec:org.grails.async.factory.groovy.AwaitablePromiseFactorySpec]/[feature:$spock_feature_0_21] -->
   
   Reuse successful test results:
   
   🔲 ♻️ Only rerun the tests that failed or were muted before
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: convert grails-converters to Groovy [grails-core]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16601:
URL: https://github.com/apache/grails-core/pull/16601#issuecomment-6110038590

   ## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16601?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `54.74820%` with `629 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 62.7005%. Comparing base ([`d45af4d`](https://app.codecov.io/gh/apache/grails-core/commit/d45af4d9adb7301b8c795dc9461fa3bb6e5435ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6df746b`](https://app.codecov.io/gh/apache/grails-core/commit/6df746b81d9231b22ae502a0bee9dd70b5c995d2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16601?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...ters/src/main/groovy/grails/converters/JSON.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fconverters%2FJSON.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9jb252ZXJ0ZXJzL0pTT04uZ3Jvb3Z5) | 39.2857% | [134 Missing and 19 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rters/src/main/groovy/grails/converters/XML.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fconverters%2FXML.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9jb252ZXJ0ZXJzL1hNTC5ncm9vdnk=) | 42.2460% | [98 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rters/marshaller/json/DomainClassMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FDomainClassMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL0RvbWFpbkNsYXNzTWFyc2hhbGxlci5ncm9vdnk=) | 52.2727% | [39 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...erters/marshaller/xml/DomainClassMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fxml%2FDomainClassMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci94bWwvRG9tYWluQ2xhc3NNYXJzaGFsbGVyLmdyb292eQ==) | 45.8333% | [34 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ovy/org/grails/web/converters/ConverterUtil.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2FConverterUtil.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvQ29udmVydGVyVXRpbC5ncm9vdnk=) | 25.4902% | [29 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...s/marshaller/xml/ValidationErrorsMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fxml%2FValidationErrorsMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci94bWwvVmFsaWRhdGlvbkVycm9yc01hcnNoYWxsZXIuZ3Jvb3Z5) | 8.6956% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../marshaller/json/ValidationErrorsMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FValidationErrorsMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL1ZhbGlkYXRpb25FcnJvcnNNYXJzaGFsbGVyLmdyb292eQ==) | 47.0588% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...configuration/ChainedConverterConfiguration.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fconfiguration%2FChainedConverterConfiguration.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvY29uZmlndXJhdGlvbi9DaGFpbmVkQ29udmVydGVyQ29uZmlndXJhdGlvbi5ncm9vdnk=) | 67.3469% | [8 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...nfiguration/ImmutableConverterConfiguration.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fconfiguration%2FImmutableConverterConfiguration.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvY29uZmlndXJhdGlvbi9JbW11dGFibGVDb252ZXJ0ZXJDb25maWd1cmF0aW9uLmdyb292eQ==) | 0.0000% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...guration/ConvertersConfigurationInitializer.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fconfiguration%2FConvertersConfigurationInitializer.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvY29uZmlndXJhdGlvbi9Db252ZXJ0ZXJzQ29uZmlndXJhdGlvbkluaXRpYWxpemVyLmdyb292eQ==) | 89.0511% | [8 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [39 more](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/grails-core/pull/16601/graphs/tree.svg?width=650&height=150&src=pr&token=qJrryhpk7u&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                                 Coverage Diff                                 @@
   ##             refactor/java-to-groovy-grails-web-common     #16601        +/-   ##
   ===================================================================================
   - Coverage                                      62.7074%   62.7005%   -0.0069%     
   - Complexity                                       30747      30780        +33     
   ===================================================================================
     Files                                             2216       2216                
     Lines                                           108622     108433       -189     
     Branches                                         20390      20395         +5     
   ===================================================================================
   - Hits                                             68114      67988       -126     
   + Misses                                           30897      30806        -91     
   - Partials                                          9611       9639        +28     
   ```
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16601?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../groovy/org/grails/plugins/codecs/JSONCodec.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fcodecs%2FJSONCodec.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvcGx1Z2lucy9jb2RlY3MvSlNPTkNvZGVjLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | |
   | [...n/groovy/org/grails/plugins/codecs/XMLCodec.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fcodecs%2FXMLCodec.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvcGx1Z2lucy9jb2RlY3MvWE1MQ29kZWMuZ3Jvb3Z5) | `100.0000% <100.0000%> (ø)` | |
   | [.../groovy/org/grails/web/converters/Converter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2FConverter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvQ29udmVydGVyLmdyb292eQ==) | `75.0000% <100.0000%> (ø)` | |
   | [...aller/ByGrailsApplicationDomainClassFetcher.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2FByGrailsApplicationDomainClassFetcher.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9CeUdyYWlsc0FwcGxpY2F0aW9uRG9tYWluQ2xhc3NGZXRjaGVyLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | |
   | [...erters/marshaller/json/CollectionMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FCollectionMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL0NvbGxlY3Rpb25NYXJzaGFsbGVyLmdyb292eQ==) | `85.7143% <100.0000%> (ø)` | |
   | [...eb/converters/marshaller/json/MapMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FMapMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL01hcE1hcnNoYWxsZXIuZ3Jvb3Z5) | `81.8182% <100.0000%> (ø)` | |
   | [...web/converters/marshaller/xml/MapMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fxml%2FMapMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci94bWwvTWFwTWFyc2hhbGxlci5ncm9vdnk=) | `87.5000% <100.0000%> (ø)` | |
   | [.../web/converters/ConvertersDomainTransformer.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fcompiler%2Fweb%2Fconverters%2FConvertersDomainTransformer.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvY29tcGlsZXIvd2ViL2NvbnZlcnRlcnMvQ29udmVydGVyc0RvbWFpblRyYW5zZm9ybWVyLmdyb292eQ==) | `80.0000% <80.0000%> (ø)` | |
   | [...grails/plugins/converters/api/ConvertersApi.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fconverters%2Fapi%2FConvertersApi.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvcGx1Z2lucy9jb252ZXJ0ZXJzL2FwaS9Db252ZXJ0ZXJzQXBpLmdyb292eQ==) | `70.0000% <83.3333%> (ø)` | |
   | [...rs/configuration/ObjectMarshallerRegisterer.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fconfiguration%2FObjectMarshallerRegisterer.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvY29uZmlndXJhdGlvbi9PYmplY3RNYXJzaGFsbGVyUmVnaXN0ZXJlci5ncm9vdnk=) | `77.7778% <83.3333%> (ø)` | |
   | ... and [46 more](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16601/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: convert grails-converters to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub) via notifications" <no...@grails.apache.org>.
testlens-app[bot] commented on PR #16601:
URL: https://github.com/apache/grails-core/pull/16601#issuecomment-6607176482

   ## 🔎 No tests executed 🔎
   
   🏷️ Commit: b0e069d666aebda8705cdd3ea753e94a72030edd
   ▶️ Tests:  0 executed
   ⚪️ Checks: 42/42 completed
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: convert grails-converters to Groovy [grails-core]

Posted by "borinquenkid (via GitHub) via notifications" <no...@grails.apache.org>.
borinquenkid commented on PR #16601:
URL: https://github.com/apache/grails-core/pull/16601#issuecomment-6760929857

   Moving this stacked draft to my fork (borinquenkid/grails-core, same branch name) to cut review noise while it is downstream of active work. The branch stays here and will be reopened upstream when it is ready to be reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: convert grails-converters to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16601:
URL: https://github.com/apache/grails-core/pull/16601#issuecomment-6197967938

   ## ✅ All tests passed ✅
   
   🏷️ Commit: efd6ea9743403093b3154b227ce433e61b868947
   ▶️ Tests:  44615 executed
   ⚪️ Checks: 84/84 completed
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: convert grails-converters to Groovy [grails-core]

Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.
borinquenkid commented on PR #16601:
URL: https://github.com/apache/grails-core/pull/16601#issuecomment-6280548376

   **Update: this branch now carries a different temporary CI commit (BLOCKER before merge).**
   
   The earlier `skipTests`/`skipCodeStyle` flag in `gradle.properties` did not help enough: the functional jobs still compile the whole repository (about 57 minutes each) on every push, so it only saved around a fifth of the time. It has been removed.
   
   In its place, every PR in this stack except #16576 (the one closest to 10.0.x) carries one temporary commit, `CHANGEME FOR ACCEPTANCE: disable PR workflow triggers`. It changes the `pull_request:` trigger of each workflow to `branches: ['CHANGEME-FOR-ACCEPTANCE']`, a branch that does not exist, so pushing, rebasing or force-pushing this branch starts no jobs.
   
   **Condition for merging this PR:** that commit must be reverted on this branch first (`git revert` of the `CHANGEME FOR ACCEPTANCE` commit), and CI must then run and be green. **The absence of CI checks on this PR is deliberate and does not mean the code was tested.** The full build runs on #16576, and each PR gets it when the PR below it has merged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: convert grails-converters to Groovy [grails-core]

Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.
borinquenkid commented on PR #16601:
URL: https://github.com/apache/grails-core/pull/16601#issuecomment-6278022173

   **Temporary CI flag on this stacked branch (BLOCKER before merge).**
   
   This Java-to-Groovy chain is a stack of PRs, and every push to any of them starts the full CI matrix, which is more runner time than the ASF allows us. Every PR in the stack except the one closest to its release branch (#16576) therefore carries one temporary commit, `CHANGEME FOR ACCEPTANCE`, that adds this to the root `gradle.properties`:
   
   ```
   skipTests=true
   skipCodeStyle=true
   ```
   
   With it, CI on this PR compiles but does not run tests or code style. The full build runs on #16576 (closest to 10.0.x), and each PR gets it when the PR below it has merged.
   
   **Condition for merging this PR:** that `gradle.properties` block (and the `CHANGEME FOR ACCEPTANCE` commit) must be dropped from this branch first, and CI must then be green with the tests running. A green check on this PR as it stands does not mean the tests ran. Rollout of the commit is branch by branch, so a branch may not carry it yet.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: convert grails-converters to Groovy [grails-core]

Posted by "borinquenkid (via GitHub) via notifications" <no...@grails.apache.org>.
borinquenkid closed pull request #16601: refactor: convert grails-converters to Groovy
URL: https://github.com/apache/grails-core/pull/16601


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org