You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Artem Harutyunyan <ar...@mesosphere.io> on 2015/12/17 18:39:42 UTC

Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41421/
-----------------------------------------------------------

(Updated Dec. 17, 2015, 9:39 a.m.)


Review request for mesos, Artem Harutyunyan and Jie Yu.


Repository: mesos


Description
-------

Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.


Diffs
-----

  src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 

Diff: https://reviews.apache.org/r/41421/diff/


Testing
-------


Thanks,

Artem Harutyunyan


Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41421/
-----------------------------------------------------------

(Updated Dec. 18, 2015, 3:48 p.m.)


Review request for mesos, Artem Harutyunyan and Jie Yu.


Bugs: MESOS-4064
    https://issues.apache.org/jira/browse/MESOS-4064


Repository: mesos


Description
-------

Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.


Diffs (updated)
-----

  src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 

Diff: https://reviews.apache.org/r/41421/diff/


Testing
-------


Thanks,

Artem Harutyunyan


Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41421/
-----------------------------------------------------------

(Updated Dec. 18, 2015, 3:09 p.m.)


Review request for mesos, Artem Harutyunyan and Jie Yu.


Bugs: MESOS-4064
    https://issues.apache.org/jira/browse/MESOS-4064


Repository: mesos


Description
-------

Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.


Diffs (updated)
-----

  src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 

Diff: https://reviews.apache.org/r/41421/diff/


Testing
-------


Thanks,

Artem Harutyunyan


Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41421/#review111219
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Dec. 17, 2015, 7:59 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41421/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 7:59 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Jie Yu.
> 
> 
> Bugs: MESOS-4064
>     https://issues.apache.org/jira/browse/MESOS-4064
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 
> 
> Diff: https://reviews.apache.org/r/41421/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41421/
-----------------------------------------------------------

(Updated Dec. 17, 2015, 11:59 a.m.)


Review request for mesos, Artem Harutyunyan and Jie Yu.


Bugs: MESOS-4064
    https://issues.apache.org/jira/browse/MESOS-4064


Repository: mesos


Description
-------

Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.


Diffs
-----

  src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 

Diff: https://reviews.apache.org/r/41421/diff/


Testing
-------


Thanks,

Artem Harutyunyan


Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41421/
-----------------------------------------------------------

(Updated Dec. 17, 2015, 10:26 a.m.)


Review request for mesos, Artem Harutyunyan and Jie Yu.


Repository: mesos


Description
-------

Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.


Diffs (updated)
-----

  src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 

Diff: https://reviews.apache.org/r/41421/diff/


Testing
-------


Thanks,

Artem Harutyunyan