You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2022/12/06 09:24:00 UTC

[jira] [Commented] (CALCITE-5360) Implement BigQuery TIMESTAMP_ADD and TIMESTAMP_DIFF

    [ https://issues.apache.org/jira/browse/CALCITE-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643744#comment-17643744 ] 

Julian Hyde commented on CALCITE-5360:
--------------------------------------

[~tanclary], I reviewed your PR, made suggestions, and also added a commit to [julianhyde/5360-timestamp-add|https://github.com/julianhyde/calcite/tree/5360-timestamp-add]; feel free to cherry-pick.

> Implement BigQuery TIMESTAMP_ADD and TIMESTAMP_DIFF
> ---------------------------------------------------
>
>                 Key: CALCITE-5360
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5360
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core
>            Reporter: TJ Banghart
>            Assignee: Tanner Clary
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Calcite already supports TIMESTAMPADD and TIMESTAMPDIFF. We should try mapping the BQ style syntax to these already implemented functions.
> We did something similar for TIMESTAMP_TRUNC and TIME_TRUNC which conveniently mapped to FLOOR in [CALCITE-5269|https://issues.apache.org/jira/browse/CALCITE-5269]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)