You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/25 10:40:04 UTC

[GitHub] [skywalking] aiyanbo opened a new pull request #4128: WIP [test/plugin] immigrate test play framework scenario

aiyanbo opened a new pull request #4128: WIP [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [-] New feature provided
   - [ ] Improve performance
   
   - Related issues
   https://github.com/apache/skywalking/issues/3583
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568889724
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=h1) Report
   > Merging [#4128](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ea9acc5c24ee386cbac1f14bb90d87944861eaa6?src=pr&el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4128/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4128      +/-   ##
   ==========================================
   + Coverage    27.2%   27.23%   +0.02%     
   ==========================================
     Files        1141     1141              
     Lines       25057    25057              
     Branches     3625     3625              
   ==========================================
   + Hits         6818     6824       +6     
   + Misses      17635    17627       -8     
   - Partials      604      606       +2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ng/apm/plugin/play/v2x/HttpFiltersInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vcGxheS0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vcGxheS92MngvSHR0cEZpbHRlcnNJbnRlcmNlcHRvci5qYXZh) | `76.92% <ø> (ø)` | |
   | [.../skywalking/apm/plugin/play/v2x/TracingFilter.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vcGxheS0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vcGxheS92MngvVHJhY2luZ0ZpbHRlci5qYXZh) | `80.55% <ø> (ø)` | |
   | [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
   | [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (+13.48%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=footer). Last update [ea9acc5...76a3bfa](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568889724
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=h1) Report
   > Merging [#4128](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ea9acc5c24ee386cbac1f14bb90d87944861eaa6?src=pr&el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4128/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4128      +/-   ##
   ==========================================
   - Coverage    27.2%   27.18%   -0.03%     
   ==========================================
     Files        1141     1141              
     Lines       25057    25057              
     Branches     3625     3625              
   ==========================================
   - Hits         6818     6812       -6     
   - Misses      17635    17642       +7     
   + Partials      604      603       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ng/apm/plugin/play/v2x/HttpFiltersInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vcGxheS0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vcGxheS92MngvSHR0cEZpbHRlcnNJbnRlcmNlcHRvci5qYXZh) | `76.92% <ø> (ø)` | |
   | [.../skywalking/apm/plugin/play/v2x/TracingFilter.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vcGxheS0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vcGxheS92MngvVHJhY2luZ0ZpbHRlci5qYXZh) | `80.55% <ø> (ø)` | |
   | [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=footer). Last update [ea9acc5...815a80a](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568889724
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@b05b45a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4128/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4128   +/-   ##
   =========================================
     Coverage          ?   27.18%           
   =========================================
     Files             ?     1141           
     Lines             ?    25057           
     Branches          ?     3625           
   =========================================
     Hits              ?     6812           
     Misses            ?    17642           
     Partials          ?      603
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=footer). Last update [b05b45a...0ba51ad](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568889724
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@e9cef69`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4128/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4128   +/-   ##
   =========================================
     Coverage          ?   27.23%           
   =========================================
     Files             ?     1141           
     Lines             ?    25057           
     Branches          ?     3625           
   =========================================
     Hits              ?     6824           
     Misses            ?    17627           
     Partials          ?      606
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...e/skywalking/apm/plugin/lettuce/v5/SWConsumer.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9TV0NvbnN1bWVyLmphdmE=) | `0% <ø> (ø)` | |
   | [...ugin/lettuce/v5/RedisChannelWriterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NoYW5uZWxXcml0ZXJJbnRlcmNlcHRvci5qYXZh) | `62.06% <ø> (ø)` | |
   | [...e/v5/RedisClusterClientConstructorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NsdXN0ZXJDbGllbnRDb25zdHJ1Y3RvckludGVyY2VwdG9yLmphdmE=) | `0% <ø> (ø)` | |
   | [...ugin/lettuce/v5/AsyncCommandMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9Bc3luY0NvbW1hbmRNZXRob2RJbnRlcmNlcHRvci5qYXZh) | `0% <ø> (ø)` | |
   | [...gin/lettuce/v5/AbstractRedisClientInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9BYnN0cmFjdFJlZGlzQ2xpZW50SW50ZXJjZXB0b3IuamF2YQ==) | `0% <ø> (ø)` | |
   | [...ettuce/v5/ClientOptionsConstructorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9DbGllbnRPcHRpb25zQ29uc3RydWN0b3JJbnRlcmNlcHRvci5qYXZh) | `0% <ø> (ø)` | |
   | [.../lettuce/v5/RedisClientConstructorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NsaWVudENvbnN0cnVjdG9ySW50ZXJjZXB0b3IuamF2YQ==) | `0% <ø> (ø)` | |
   | [...skywalking/apm/plugin/lettuce/v5/SWBiConsumer.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9TV0JpQ29uc3VtZXIuamF2YQ==) | `0% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=footer). Last update [e9cef69...15b0eb8](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568889724
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=h1) Report
   > Merging [#4128](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e25b1e60085224d78210dc590292ebf939565742?src=pr&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4128/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4128      +/-   ##
   ==========================================
   - Coverage   27.23%   27.17%   -0.06%     
   ==========================================
     Files        1141     1141              
     Lines       25057    25057              
     Branches     3625     3625              
   ==========================================
   - Hits         6824     6810      -14     
   - Misses      17627    17644      +17     
   + Partials      606      603       -3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ng/apm/plugin/play/v2x/HttpFiltersInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vcGxheS0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vcGxheS92MngvSHR0cEZpbHRlcnNJbnRlcmNlcHRvci5qYXZh) | `76.92% <ø> (ø)` | |
   | [.../skywalking/apm/plugin/play/v2x/TracingFilter.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vcGxheS0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vcGxheS92MngvVHJhY2luZ0ZpbHRlci5qYXZh) | `80.55% <ø> (ø)` | |
   | [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (-13.49%)` | :arrow_down: |
   | [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `73.77% <0%> (-3.28%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=footer). Last update [e25b1e6...48f3e82](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wayilau commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wayilau commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361355173
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -540,4 +540,28 @@ jobs:
       - name: Build the Docker image
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run lettuce-scenario 5.x (17)
-        run: bash test/plugin/run.sh lettuce-scenario
\ No newline at end of file
+        run: bash test/plugin/run.sh lettuce-scenario
+  PlayFramework:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run Play! Framework
+        run: bash test/plugin/run.sh play-scenario
 
 Review comment:
   As it runs fast enough, may be it should combined with lettuce.  what about you ? @wu-sheng 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aiyanbo commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
aiyanbo commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361413517
 
 

 ##########
 File path: test/plugin/scenarios/play-scenario/build.sbt
 ##########
 @@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+name := """play-scenario"""
 
 Review comment:
   No, this is project name in SBT. And the `""""""` style is Scala Strip Strings

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wayilau commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wayilau commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361384191
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -540,4 +540,28 @@ jobs:
       - name: Build the Docker image
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run lettuce-scenario 5.x (17)
-        run: bash test/plugin/run.sh lettuce-scenario
\ No newline at end of file
+        run: bash test/plugin/run.sh lettuce-scenario
+  PlayFramework:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run Play! Framework
+        run: bash test/plugin/run.sh play-scenario
 
 Review comment:
   After you add play to lettuce, please rename LETTUCE to LETTUCE_PlayFramework. @aiyanbo 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io commented on issue #4128: WIP [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4128: WIP [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568889724
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=h1) Report
   > Merging [#4128](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1e9f929f978ac7fbad11832176ce7b0190181a92?src=pr&el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4128/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4128      +/-   ##
   ==========================================
   + Coverage   27.17%   27.23%   +0.05%     
   ==========================================
     Files        1141     1141              
     Lines       25057    25057              
     Branches     3625     3625              
   ==========================================
   + Hits         6810     6824      +14     
   + Misses      17644    17627      -17     
   - Partials      603      606       +3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `77.04% <0%> (+3.27%)` | :arrow_up: |
   | [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (+13.48%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=footer). Last update [1e9f929...50de6fb](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4128: WIP [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4128: WIP [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568883570
 
 
   Please follow #4121, and make play framework as default plugin.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568944347
 
 
   Even I resolved the conflicts, the CI still shows error. Please recheck.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wayilau commented on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wayilau commented on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568943140
 
 
   @aiyanbo Please resolve the conflicts first. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361368801
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -540,4 +540,28 @@ jobs:
       - name: Build the Docker image
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run lettuce-scenario 5.x (17)
-        run: bash test/plugin/run.sh lettuce-scenario
\ No newline at end of file
+        run: bash test/plugin/run.sh lettuce-scenario
+  PlayFramework:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run Play! Framework
+        run: bash test/plugin/run.sh play-scenario
 
 Review comment:
   Yes, PlayFramework test cases should be merged into Lettuce group.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wayilau commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wayilau commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361383869
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -540,4 +540,28 @@ jobs:
       - name: Build the Docker image
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run lettuce-scenario 5.x (17)
-        run: bash test/plugin/run.sh lettuce-scenario
\ No newline at end of file
+        run: bash test/plugin/run.sh lettuce-scenario
+  PlayFramework:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run Play! Framework
+        run: bash test/plugin/run.sh play-scenario
 
 Review comment:
   @aiyanbo execution time should less than 35m, i think put LETTUCE and Play  together is more better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aiyanbo commented on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
aiyanbo commented on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568958347
 
 
   > @aiyanbo Are you in the SkyWalking slack? There is one feedback about this Play plugin from India. If you have interests and time, please take a look. I am not familiar with the Play ecosystem. Can't help much.
   
   Yes, i was joined SkyWalking channel. I will help others using SkyWalking in PlayFramework.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aiyanbo commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
aiyanbo commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361384467
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -540,4 +540,28 @@ jobs:
       - name: Build the Docker image
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run lettuce-scenario 5.x (17)
-        run: bash test/plugin/run.sh lettuce-scenario
\ No newline at end of file
+        run: bash test/plugin/run.sh lettuce-scenario
+  PlayFramework:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run Play! Framework
+        run: bash test/plugin/run.sh play-scenario
 
 Review comment:
   > After you add play to lettuce, please rename LETTUCE to LETTUCE_PlayFramework. @aiyanbo
   
   👌

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wayilau commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wayilau commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361353644
 
 

 ##########
 File path: test/plugin/scenarios/play-scenario/support-version.list
 ##########
 @@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# lists your version here
+2.7.0
 
 Review comment:
   Where's 2.6.x version said in docs/en/setup/service-agent/java-agent/Supported-list.md

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wayilau commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wayilau commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361415658
 
 

 ##########
 File path: test/plugin/scenarios/play-scenario/build.sbt
 ##########
 @@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+name := """play-scenario"""
 
 Review comment:
   I got it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361309295
 
 

 ##########
 File path: docs/en/setup/service-agent/java-agent/Supported-list.md
 ##########
 @@ -12,7 +12,7 @@
   * [Spring Webflux](https://docs.spring.io/spring/docs/current/spring-framework-reference/web-reactive.html) 5.x (Optional²)
   * [Undertow](http://undertow.io/)  1.3.0.Final -> 2.0.27.Final
   * [RESTEasy](https://resteasy.github.io/)  3.1.0.Final -> 3.7.0.Final
-  * [Play Framework](https://www.playframework.com/) 2.6.x -> 2.7.x (Optional²)
+  * [Play Framework](https://www.playframework.com/) 2.6.x -> 2.8.x
 
 Review comment:
   You should remove the play from here, https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/README.md#optional-plugins

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568954169
 
 
   @aiyanbo Are you in the SkyWalking slack? There is one feedback about this Play plugin from India. If you have interests and time, please take a look. I am not familiar with the Play ecosystem. Can't help much.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] dmsolr commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361418577
 
 

 ##########
 File path: test/plugin/scenarios/play-scenario/conf/logback.xml
 ##########
 @@ -0,0 +1,53 @@
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  ~
+  -->
+
+<!-- https://www.playframework.com/documentation/latest/SettingsLogger -->
+<configuration>
+
+  <conversionRule conversionWord="coloredLevel" converterClass="play.api.libs.logback.ColoredLevel" />
+
+  <appender name="FILE" class="ch.qos.logback.core.FileAppender">
+    <file>${application.home:-.}/logs/application.log</file>
+    <encoder>
+      <pattern>%date [%level] from %logger in %thread - %message%n%xException</pattern>
+    </encoder>
+  </appender>
+
+  <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+    <encoder>
+      <pattern>%coloredLevel %logger{15} - %message%n%xException{10}</pattern>
+    </encoder>
+  </appender>
 
 Review comment:
   Hi @aiyanbo , Test-framework will only print logs of `System.err` printed.
   We do not recommend to log into files, and it is unuseful. Because we cannot get them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wayilau commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wayilau commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361404623
 
 

 ##########
 File path: test/plugin/scenarios/play-scenario/build.sbt
 ##########
 @@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+name := """play-scenario"""
 
 Review comment:
   Is this a mistake ?  @aiyanbo 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568889724
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=h1) Report
   > Merging [#4128](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ea9acc5c24ee386cbac1f14bb90d87944861eaa6?src=pr&el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4128/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4128      +/-   ##
   ==========================================
   - Coverage   27.25%   27.18%   -0.08%     
   ==========================================
     Files        1141     1141              
     Lines       25057    25057              
     Branches     3625     3625              
   ==========================================
   - Hits         6830     6812      -18     
   - Misses      17620    17642      +22     
   + Partials      607      603       -4
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ng/apm/plugin/play/v2x/HttpFiltersInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vcGxheS0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vcGxheS92MngvSHR0cEZpbHRlcnNJbnRlcmNlcHRvci5qYXZh) | `76.92% <ø> (ø)` | |
   | [.../skywalking/apm/plugin/play/v2x/TracingFilter.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vcGxheS0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vcGxheS92MngvVHJhY2luZ0ZpbHRlci5qYXZh) | `80.55% <ø> (ø)` | |
   | [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
   | [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (-13.49%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=footer). Last update [ea9acc5...815a80a](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aiyanbo commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
aiyanbo commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361382760
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -540,4 +540,28 @@ jobs:
       - name: Build the Docker image
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run lettuce-scenario 5.x (17)
-        run: bash test/plugin/run.sh lettuce-scenario
\ No newline at end of file
+        run: bash test/plugin/run.sh lettuce-scenario
+  PlayFramework:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run Play! Framework
+        run: bash test/plugin/run.sh play-scenario
 
 Review comment:
   @wayilau @wu-sheng Your mean is add PlayFramework test to LETTUCE job as a step ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aiyanbo commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
aiyanbo commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361383561
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -540,4 +540,28 @@ jobs:
       - name: Build the Docker image
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run lettuce-scenario 5.x (17)
-        run: bash test/plugin/run.sh lettuce-scenario
\ No newline at end of file
+        run: bash test/plugin/run.sh lettuce-scenario
+  PlayFramework:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run Play! Framework
+        run: bash test/plugin/run.sh play-scenario
 
 Review comment:
   @wu-sheng @wayilau Can i merge LETTUCE and PlayFramework into Ehcache_Undertow_Jedis job ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng merged pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568889724
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=h1) Report
   > Merging [#4128](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e25b1e60085224d78210dc590292ebf939565742?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4128/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4128   +/-   ##
   =======================================
     Coverage   27.23%   27.23%           
   =======================================
     Files        1141     1141           
     Lines       25057    25057           
     Branches     3625     3625           
   =======================================
     Hits         6824     6824           
     Misses      17627    17627           
     Partials      606      606
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ng/apm/plugin/play/v2x/HttpFiltersInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vcGxheS0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vcGxheS92MngvSHR0cEZpbHRlcnNJbnRlcmNlcHRvci5qYXZh) | `76.92% <ø> (ø)` | |
   | [.../skywalking/apm/plugin/play/v2x/TracingFilter.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vcGxheS0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vcGxheS92MngvVHJhY2luZ0ZpbHRlci5qYXZh) | `80.55% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=footer). Last update [e25b1e6...31ecead](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568959707
 
 
   > Yes, i was joined SkyWalking channel. I will help others using SkyWalking in PlayFramework
   
   Very appreciated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wayilau commented on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
wayilau commented on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-569025615
 
 
   LGTM. 
   Waiting other committers review. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aiyanbo commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
aiyanbo commented on a change in pull request #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#discussion_r361385263
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -540,4 +540,28 @@ jobs:
       - name: Build the Docker image
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run lettuce-scenario 5.x (17)
-        run: bash test/plugin/run.sh lettuce-scenario
\ No newline at end of file
+        run: bash test/plugin/run.sh lettuce-scenario
+  PlayFramework:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run Play! Framework
+        run: bash test/plugin/run.sh play-scenario
 
 Review comment:
   @wu-sheng @wayilau I was merged Play into LETTUCE, but can i merged Play and LETTUCE into Ehcache_Undertow_Jedis?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4128: [test/plugin] immigrate test play framework scenario
URL: https://github.com/apache/skywalking/pull/4128#issuecomment-568889724
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=h1) Report
   > Merging [#4128](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e25b1e60085224d78210dc590292ebf939565742?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4128/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4128   +/-   ##
   =======================================
     Coverage   27.23%   27.23%           
   =======================================
     Files        1141     1141           
     Lines       25057    25057           
     Branches     3625     3625           
   =======================================
     Hits         6824     6824           
     Misses      17627    17627           
     Partials      606      606
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ng/apm/plugin/play/v2x/HttpFiltersInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vcGxheS0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vcGxheS92MngvSHR0cEZpbHRlcnNJbnRlcmNlcHRvci5qYXZh) | `76.92% <ø> (ø)` | |
   | [.../skywalking/apm/plugin/play/v2x/TracingFilter.java](https://codecov.io/gh/apache/skywalking/pull/4128/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vcGxheS0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vcGxheS92MngvVHJhY2luZ0ZpbHRlci5qYXZh) | `80.55% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=footer). Last update [e25b1e6...98f4eaf](https://codecov.io/gh/apache/skywalking/pull/4128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services