You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "r4mercur (via GitHub)" <gi...@apache.org> on 2026/09/04 16:29:00 UTC
[PR] SOLR-18169: Add IllegalArgumentException when slim image is used for … [solr]
r4mercur opened a new pull request, #4876:
URL: https://github.com/apache/solr/pull/4876
…creating tech-products without documentation
https://issues.apache.org/jira/browse/SOLR-18169
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-18169: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Our "slim" distribution shouldn't have examples.
Furthermore, an attempt to use bin/solr start -e techproducts etc. should yield a helpful error message.
# Solution
Instead of write an simple echo() statement. I introduced an IllegalArgumentException with a more detailed error message. The message recommands the user to use the full docker image instead of the slim one.
# AI Agents
I used claude agent for the explanation of the problem / description of the ticket. The testcase is also designed by the agent.
# Tests
The testcase is simulating the "slim" distribution and checking that when there are no exampledocs that the new exception is thrown.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
- [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18169: Add IllegalArgumentException when slim image is used for … [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4876:
URL: https://github.com/apache/solr/pull/4876#issuecomment-5544078600
can you also do the same thing for the `films` example? it fails silently right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18169: Add IllegalArgumentException when slim image is used for … [solr]
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on code in PR #4876:
URL: https://github.com/apache/solr/pull/4876#discussion_r3936460389
##########
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##########
@@ -410,8 +410,10 @@ protected void runExample(CommandLine cli, String exampleName) throws Exception
postTool.runTool(postToolCli);
} else {
- echo(
- "exampledocs directory not found, skipping indexing step for the techproducts example");
+ throw new IllegalArgumentException(
+ "This Solr distribution does not include example data."
+ + "('slim' Docker image). Please use the full Solr "
+ + "distribution to run the techproducts example.");
Review Comment:
It is possible this is because of the slim docker image, but it's not the only reason.
```suggestion
"This Solr distribution does not include example data."
+ "This is expected when using the 'slim' Solr distribution."
+ "Please use the full Solr distribution to run the 'techproducts' example.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18169: Add IllegalArgumentException when slim image is used for … [solr]
Posted by "r4mercur (via GitHub)" <gi...@apache.org>.
r4mercur closed pull request #4876: SOLR-18169: Add IllegalArgumentException when slim image is used for …
URL: https://github.com/apache/solr/pull/4876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org