You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/07/24 20:24:52 UTC
[GitHub] [trafficserver] shinrich opened a new pull request #7041: Add checks to catch tunnel memory leaks
shinrich opened a new pull request #7041:
URL: https://github.com/apache/trafficserver/pull/7041
Attempt to debug issue #6783
Not clear anything here will fix that issue, but the added asserts should trigger if the state machine shuts down without freeing the chunked_buffer.
In our production with jemalloc profiling I was not able to catch any allocation stacks that included generate_chunked_content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7041: Add checks to catch tunnel memory leaks
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7041:
URL: https://github.com/apache/trafficserver/pull/7041#issuecomment-681123564
This has not tripped on Docs :-/.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich closed pull request #7041: Add checks to catch tunnel memory leaks
Posted by GitBox <gi...@apache.org>.
shinrich closed pull request #7041:
URL: https://github.com/apache/trafficserver/pull/7041
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7041: Add checks to catch tunnel memory leaks
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7041:
URL: https://github.com/apache/trafficserver/pull/7041#issuecomment-715406826
Please remember to remove Milestones and Projects when closing a PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a change in pull request #7041: Add checks to catch tunnel memory leaks
Posted by GitBox <gi...@apache.org>.
bryancall commented on a change in pull request #7041:
URL: https://github.com/apache/trafficserver/pull/7041#discussion_r461667682
##########
File path: proxy/http/HttpTunnel.cc
##########
@@ -525,6 +529,16 @@ HttpTunnel::alloc_consumer()
return nullptr;
}
+void
+HttpTunnel::assert_freed_buffers()
+{
+ for (auto &producer : producers) {
Review comment:
Also, how about being a const method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #7041: Add checks to catch tunnel memory leaks
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7041:
URL: https://github.com/apache/trafficserver/pull/7041#issuecomment-710042279
Closing this. Didn't seem to help catch the memory leak observed on docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a change in pull request #7041: Add checks to catch tunnel memory leaks
Posted by GitBox <gi...@apache.org>.
bneradt commented on a change in pull request #7041:
URL: https://github.com/apache/trafficserver/pull/7041#discussion_r460443871
##########
File path: proxy/http/HttpTunnel.cc
##########
@@ -525,6 +529,16 @@ HttpTunnel::alloc_consumer()
return nullptr;
}
+void
+HttpTunnel::assert_freed_buffers()
+{
+ for (auto &producer : producers) {
Review comment:
I suggest `const auto&`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7041: Add checks to catch tunnel memory leaks
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7041:
URL: https://github.com/apache/trafficserver/pull/7041#issuecomment-674227468
[approve ci docs]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org