[GitHub] [cassandra] jacek-lewandowski commented on a change in pull request #1314: CASSANDRA-17072-4.0: Fix ignored client warnings in DebuggableThreadPoolExecutor

[GitBox <gi...@apache.org>]

jacek-lewandowski commented on a change in pull request #1314:
URL: https://github.com/apache/cassandra/pull/1314#discussion_r746895619



##########
File path: src/java/org/apache/cassandra/cql3/statements/schema/CreateKeyspaceStatement.java
##########
@@ -87,10 +83,6 @@ public Keyspaces apply(Keyspaces schema)
         keyspace.params.validate(keyspaceName);
         Keyspaces keyspaces = schema.withAddedOrUpdated(keyspace);
 
-        int newNumWarnings = ClientWarn.instance.numWarnings();
-        if (newNumWarnings > previousNumWarnings)
-            clientWarnings.addAll(ClientWarn.instance.getWarnings().subList(previousNumWarnings, newNumWarnings));
-

Review comment:
       I don't think we are ignoring anything. AFAIR client warning works in the way that once we start processing a query, client warnings state is initialized and since that time whenever we do `ClientWarn.instance.warn` it is added to the client warnings internal state which is for this particular client request. The workaround here was because state of client warnings was not passed from the initial thread which processed the request to the subtasks processed in different threads (in this case, the task was executed in migration stage).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org