[jira] [Commented] (ACCUMULO-4710) Replace use of Guava hash package

["Michael Miller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362829#comment-16362829 ] 

Michael Miller commented on ACCUMULO-4710:
------------------------------------------

The Guava Beta classes need to be looked at on a class by class basis, whether they are a risk to use or not.  The classes in the hash package seem stable enough so closing this ticket for now.

> Replace use of Guava hash package
> ---------------------------------
>
>                 Key: ACCUMULO-4710
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4710
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.8.1
>            Reporter: Michael Miller
>            Priority: Major
>             Fix For: 2.0.0
>
>
> We use a few of the Guava classes from the com.google.common.hash package, all of which are Beta as of Guava release 23.  These should be replaced with standard Java code to prevent future issues.
> This should definitely be fixed in 2.0 but I am not sure if it would break sampling in already released versions of 1.8.  There shouldn't be any Guava Beta in 1.7.
> Here are the classes used in 2.0:
> {code}
> ./core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java:import com.google.common.hash.HashCode;
> ./core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java:import com.google.common.hash.Hasher;
> ./core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java:import com.google.common.hash.Hashing;
> ./core/src/main/java/org/apache/accumulo/core/summary/Gatherer.java:import com.google.common.hash.Hashing;
> ./core/src/main/java/org/apache/accumulo/core/client/summary/SummarizerConfiguration.java:import com.google.common.hash.Hasher;
> ./core/src/main/java/org/apache/accumulo/core/client/summary/SummarizerConfiguration.java:import com.google.common.hash.Hashing;
> ./core/src/main/java/org/apache/accumulo/core/client/sample/AbstractHashSampler.java:import com.google.common.hash.HashFunction;
> ./core/src/main/java/org/apache/accumulo/core/client/sample/AbstractHashSampler.java:import com.google.common.hash.Hasher;
> ./core/src/main/java/org/apache/accumulo/core/client/sample/AbstractHashSampler.java:import com.google.common.hash.Hashing;
> ./core/src/main/java/org/apache/accumulo/core/sample/impl/DataoutputHasher.java:import com.google.common.hash.Hasher;
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)