You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/11/29 01:30:45 UTC
[GitHub] [mynewt-nimble] MarceauFillon opened a new pull request #1113: host/ble_att_svr: Reset handles index on attributes reset.
MarceauFillon opened a new pull request #1113:
URL: https://github.com/apache/mynewt-nimble/pull/1113
Resets handles index when server's attributes are reset.
Prevents mix-up when attributes are cached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] MarceauFillon commented on pull request #1113: host/ble_att_svr: Reset handles index on attributes reset.
Posted by GitBox <gi...@apache.org>.
MarceauFillon commented on pull request #1113:
URL: https://github.com/apache/mynewt-nimble/pull/1113#issuecomment-983173356
@sjanc is the target branch wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] MarceauFillon commented on pull request #1113: host/ble_att_svr: Reset handles index on attributes reset.
Posted by GitBox <gi...@apache.org>.
MarceauFillon commented on pull request #1113:
URL: https://github.com/apache/mynewt-nimble/pull/1113#issuecomment-987578659
Done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #1113: host/ble_att_svr: Reset handles index on attributes reset.
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #1113:
URL: https://github.com/apache/mynewt-nimble/pull/1113#issuecomment-982757497
you may need to rebase to make CI happy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrewleech commented on pull request #1113: host/ble_att_svr: Reset handles index on attributes reset.
Posted by GitBox <gi...@apache.org>.
andrewleech commented on pull request #1113:
URL: https://github.com/apache/mynewt-nimble/pull/1113#issuecomment-988336163
As some background to this change, we're using nimble as the primary BLE stack in micropython.
During the initial startup of the stack we register the standard gap/gatt services: https://github.com/micropython/micropython/blob/851ecb2da178fff0b60aefdb5af502f28787a7ec/extmod/nimble/modbluetooth_nimble.c#L653
The micropython end user application would later typically define all the desired services/characteristics which is managed dynamically by resetting the registration and building up the required structs to be registered: https://github.com/micropython/micropython/blob/851ecb2da178fff0b60aefdb5af502f28787a7ec/extmod/nimble/modbluetooth_nimble.c#L907
This has been working very well, however we recently discoevered that the handles would continue incrementing over each registration reset, causing difficulties with any paired devices which have cached services/characteristics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #1113: host/ble_att_svr: Reset handles index on attributes reset.
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #1113:
URL: https://github.com/apache/mynewt-nimble/pull/1113#issuecomment-983375692
ahh yes, please make PR against master branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org