You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by borisroman <gi...@git.apache.org> on 2015/08/17 17:11:17 UTC
[GitHub] cloudstack pull request: Refactored Nic.java for readability.
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/707
Refactored Nic.java for readability.
Only changed names and reorganized them! No functional implementation change.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8736
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/707.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #707
----
commit 3ab7e477aa6c9a02db93344aaa36d00d231a3007
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-08-17T14:20:51Z
Refactored Nic.java for readability.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
commit 80bcfb12227080078cfa6760c0c4a9feb0dec51a
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-08-17T14:21:51Z
Changed methodnames according to Nic.java refactor.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
commit af199e7057033a5c77b176ca1c2040f3d07ad16b
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-08-17T14:54:41Z
Fixed NicVO.java due to regression from Nic.java refactor.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored Nic.java for readability.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/707
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored Nic.java for readability.
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/707#issuecomment-132444220
build is successful now. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored Nic.java for readability.
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/707#issuecomment-132154456
LGTM to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored Nic.java for readability.
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/707#issuecomment-131864788
80bcfb1 and af199e7 are not atomic then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored Nic.java for readability.
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/707#issuecomment-132187698
@karuturi I see, fixed them in a new commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored Nic.java for readability.
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/707#issuecomment-131871473
@DaanHoogland You are right. I squashed to commits together so there will not be a non-working commit left.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored Nic.java for readability.
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/707#issuecomment-132175228
I seeing below errors after applying this patch. Please do a noredist build as mentioned at https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+CloudStack#HowtobuildCloudStack-BuildingCloudStack
```
[ERROR] /root/source/cloudstack/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java:[270,50] error: cannot find symbol
[ERROR] symbol: method getDns1()
location: variable publicNicProfile of type NicProfile
/root/source/cloudstack/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java:[271,50] error: cannot find symbol
[ERROR] symbol: method getDns2()
location: variable publicNicProfile of type NicProfile
/root/source/cloudstack/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java:[272,40] error: cannot find symbol
[ERROR] symbol: method getGateway()
location: variable publicNicProfile of type NicProfile
/root/source/cloudstack/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java:[273,57] error: cannot find symbol
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---