[GitHub] [commons-pool] kinow commented on pull request #199: [POOL-393] Improve BaseGenericObjectPool's JMX Register performance

[GitBox <gi...@apache.org>]

kinow commented on PR #199:
URL: https://github.com/apache/commons-pool/pull/199#issuecomment-1364545324

   The class docs state it's intended to be thread-safe, and that `i` variable's scope is limited to the method. It should be fine regarding other threads trying to instantiate it I think.
   
   I think @garydgregory is right asking if it there is a scenario where it just keeps going in a loop trying to register `jmxbean`, `jmxbean1`, `jmxbean2`, ...`, jmxbean9999`. But I think if that's a possible scenario, that deserves a separate issue as I think that affects `master` too (or at least deserves a comment in the javadocs or in the code body telling others why that wouldn't happen).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org