You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org> on 2007/01/15 15:41:27 UTC

[jira] Created: (QPID-296) C++ Header guards may not be compliant with C++ standard

C++ Header guards may not be compliant with C++ standard
--------------------------------------------------------

                 Key: QPID-296
                 URL: https://issues.apache.org/jira/browse/QPID-296
             Project: Qpid
          Issue Type: Bug
          Components: C++ Broker, C++ Client, Code Generator
            Reporter: Andrew Stitcher
            Priority: Minor


According to the C++ standard symbols that have a single "_" followed by an uppercase
letter and symbols starting with "__" (double underscore are reserved for the implementer (That is usually the
compiler/library writer). 

There are numerous header files with guards that violate this standard in the C++ source base.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (QPID-296) C++ Header guards may not be compliant with C++ standard

Posted by "Alan Conway (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan Conway closed QPID-296.
----------------------------

    Resolution: Fixed

> C++ Header guards may not be compliant with C++ standard
> --------------------------------------------------------
>
>                 Key: QPID-296
>                 URL: https://issues.apache.org/jira/browse/QPID-296
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client, Code Generator
>            Reporter: Andrew Stitcher
>            Assignee: Kim van der Riet
>            Priority: Minor
>
> According to the C++ standard symbols that have a single "_" followed by an uppercase
> letter and symbols starting with "__" (double underscore are reserved for the implementer (That is usually the
> compiler/library writer). 
> There are numerous header files with guards that violate this standard in the C++ source base.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (QPID-296) C++ Header guards may not be compliant with C++ standard

Posted by "Kim van der Riet (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim van der Riet resolved QPID-296.
-----------------------------------

    Resolution: Fixed

All generated C++ headers now take the form namespace1_namespace2_classname__. As these all pertain to framing, this becomes "qpid_framing_classname__".

> C++ Header guards may not be compliant with C++ standard
> --------------------------------------------------------
>
>                 Key: QPID-296
>                 URL: https://issues.apache.org/jira/browse/QPID-296
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client, Code Generator
>            Reporter: Andrew Stitcher
>         Assigned To: Kim van der Riet
>            Priority: Minor
>
> According to the C++ standard symbols that have a single "_" followed by an uppercase
> letter and symbols starting with "__" (double underscore are reserved for the implementer (That is usually the
> compiler/library writer). 
> There are numerous header files with guards that violate this standard in the C++ source base.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (QPID-296) C++ Header guards may not be compliant with C++ standard

Posted by "Kim van der Riet (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim van der Riet reopened QPID-296:
-----------------------------------


The generated headers have been fixed, the non-generated issues still need to be fixed.

> C++ Header guards may not be compliant with C++ standard
> --------------------------------------------------------
>
>                 Key: QPID-296
>                 URL: https://issues.apache.org/jira/browse/QPID-296
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client, Code Generator
>            Reporter: Andrew Stitcher
>         Assigned To: Kim van der Riet
>            Priority: Minor
>
> According to the C++ standard symbols that have a single "_" followed by an uppercase
> letter and symbols starting with "__" (double underscore are reserved for the implementer (That is usually the
> compiler/library writer). 
> There are numerous header files with guards that violate this standard in the C++ source base.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (QPID-296) C++ Header guards may not be compliant with C++ standard

Posted by "Kim van der Riet (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim van der Riet reassigned QPID-296:
-------------------------------------

    Assignee: Kim van der Riet

> C++ Header guards may not be compliant with C++ standard
> --------------------------------------------------------
>
>                 Key: QPID-296
>                 URL: https://issues.apache.org/jira/browse/QPID-296
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client, Code Generator
>            Reporter: Andrew Stitcher
>         Assigned To: Kim van der Riet
>            Priority: Minor
>
> According to the C++ standard symbols that have a single "_" followed by an uppercase
> letter and symbols starting with "__" (double underscore are reserved for the implementer (That is usually the
> compiler/library writer). 
> There are numerous header files with guards that violate this standard in the C++ source base.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira