[GitHub] [bookkeeper] eolivelli edited a comment on issue #2612: Wrong ReadLastAddConfirmed logic that can lead to data loss in client applications

[GitBox <gi...@apache.org>]

eolivelli edited a comment on issue #2612:
URL: https://github.com/apache/bookkeeper/issues/2612#issuecomment-781341929


   I wonder how is it possible to run the bookie without data but preserving the bookie identity in production.
   By the way, it may happen if you have journalSyncData=false or some other faulty filesystem (losing writes to the journal).
   
   I agree that there is something wrong in `checkCovered`, the code returns `true` in case there is no reason to return `false` but we also must check that we do have a good reason to return `true` (enough successful/non unknown responses?).
   
   One problem is that NoSuchEntry may happen in this case of unpredictable Bookie behaviour and it may be also legit, in case of an healthy bookie that did not receive the entry (AQ < WQ). 
   
   I would like not to fall again into this issue, that was fixed by f373cb5. 
   https://github.com/apache/bookkeeper/issues/2273
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org