You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2016/04/15 20:51:11 UTC
[GitHub] nifi pull request: NIFI-1551: Prepare for introduction of Authoriz...
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/359
NIFI-1551: Prepare for introduction of Authorizer usage
- Removing the AuthorityProvider.
- Refactoring REST API in preparation for introduction of the Authorizer.
- Updating UI accordingly.
- Removing unneeded properties from nifi.properties.
After this PR has been merge, the UI will no longer authorize requests when secured. Authentication remains but authorization will follow in a subsequent PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-1551
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/359.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #359
----
commit 45334cdad5c18db438c4252a33d55c2370aa1f71
Author: Matt Gilman <ma...@gmail.com>
Date: 2016-04-15T18:49:00Z
NIFI-1551:
- Removing the AuthorityProvider.
- Refactoring REST API in preparation for introduction of the Authorizer.
- Updating UI accordingly.
- Removing unneeded properties from nifi.properties.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1551: Prepare for introduction of Authoriz...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/359#issuecomment-210612644
Looks good. I verified that I was able to start NiFi using both secure and non-secure ports. I was then able to verify that I was able to add each component, update it, and delete it, and all of those functions worked properly on both secure & non-secure ports. Of course, the authorization checks was not happening, as you've removed that part for now but all actions were still completed successfully.
The only things that I did find not working were changing the color of a component and starting a Reporting Task. Once these are addressed, I'll be a +1.
Thanks
-Mark
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1551: Prepare for introduction of Authoriz...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/359#issuecomment-210618998
Looks like the latest commit addresses both issues outlined above. Will merge into master.
Thanks for knocking this out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1551: Prepare for introduction of Authoriz...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/359
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---