[GitHub] [bigtop] guyuqi commented on a change in pull request #620: BIGTOP-3319: Add Logstash as Bigtop component

[GitBox <gi...@apache.org>]

guyuqi commented on a change in pull request #620: BIGTOP-3319: Add Logstash as Bigtop component
URL: https://github.com/apache/bigtop/pull/620#discussion_r405234038
 
 

 ##########
 File path: bigtop-packages/src/common/logstash/patch0-logstash.diff
 ##########
 @@ -0,0 +1,2393 @@
+diff -ruaN logstash-5.4.1/bin/bundle linaro-logstash-5.4.1/bin/bundle
 
 Review comment:
   Thanks for comment, evans.
   1. Pick the logstash version: 5.4.1. It corresponds to the elasticsearch version in Bigtop.
   2.  `patch0-logstash.diff` is to support Arm64.
   The Jruby-1.9 in logstash-5.4.1 doesn't support Arm64 due to the fact that Jffi 1.2.12 which Jruby 1.9 depends on has no native AArch64 libraries. Also see:  [jffi](https://github.com/jnr/jffi/pull/32), [jruby1](https://github.com/jruby/jruby/pull/4548), [jruby2](https://github.com/jruby/jruby/pull/4567).
   So `patch0-logstash.diff` upgraded jruby to 9K and also fix dependency issues for Arm64.
   The modification for Arm64 support was archived in [linaro repo](https://git.linaro.org/leg/bigdata/logstash.git) and `patch0-logstash.diff` comes from it.
   
   
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services