You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Beam JIRA Bot (Jira)" <ji...@apache.org> on 2021/05/12 17:20:02 UTC
[jira] [Commented] (BEAM-6963) Bug in RuntimeValueProvider JSON
serialization
[ https://issues.apache.org/jira/browse/BEAM-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343391#comment-17343391 ]
Beam JIRA Bot commented on BEAM-6963:
-------------------------------------
This issue is P2 but has been unassigned without any comment for 60 days so it has been labeled "stale-P2". If this issue is still affecting you, we care! Please comment and remove the label. Otherwise, in 14 days the issue will be moved to P3.
Please see https://beam.apache.org/contribute/jira-priorities/ for a detailed explanation of what these priorities mean.
> Bug in RuntimeValueProvider JSON serialization
> ----------------------------------------------
>
> Key: BEAM-6963
> URL: https://issues.apache.org/jira/browse/BEAM-6963
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.11.0
> Reporter: Balázs Németh
> Priority: P2
> Labels: Clarified, stale-P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Classes affected:
> org.apache.beam.sdk.options.ValueProvider.Serializer
> org.apache.beam.sdk.options.ValueProvider.Deserializer
> The problem is that according to the JsonDeserializer documentation, the deserialize method isn't executed for null nodes:
> ( [https://static.javadoc.io/com.fasterxml.jackson.core/jackson-databind/2.9.6/com/fasterxml/jackson/databind/JsonDeserializer.html#deserialize(com.fasterxml.jackson.core.JsonParser,%20com.fasterxml.jackson.databind.DeserializationContext)|https://static.javadoc.io/com.fasterxml.jackson.core/jackson-databind/2.9.6/com/fasterxml/jackson/databind/JsonDeserializer.html#deserialize(com.fasterxml.jackson.core.JsonParser,%20com.fasterxml.jackson.databind.DeserializationContext] )
> )
> "Note that this method is never called for JSON null literal, and thus deserializers need (and should) not check for it."
> If we serialize a RuntimeValueProvider, the isAccessible() will return false, so we call a writeNull(). During deserialization this isn't handled properly as mentioned and our deserialization will return null.
> The end result is that getters with ValueProvider return values will return "null". AFAIK ValueProvider getters should be never null.
> My guess is that either we should completely omit serializing RuntimeValueProviders, or during deserialization the proper runtime value provider should be created again - which requires more than just a simple "null" being present in the json.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)