[GitHub] [pulsar] srkukarni commented on a change in pull request #3874: [ISSUE 3763] - Implementing Function authorization

[GitBox <gi...@apache.org>]

srkukarni commented on a change in pull request #3874: [ISSUE 3763] - Implementing Function authorization
URL: https://github.com/apache/pulsar/pull/3874#discussion_r268894692
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerStarter.java
 ##########
 @@ -166,6 +166,12 @@ private static boolean argsContains(String[] args, String arg) {
                     "c-" + brokerConfig.getClusterName()
                         + "-fw-" + hostname
                         + "-" + workerConfig.getWorkerPort());
+                // inherit broker authorization setting
+                workerConfig.setAuthorizationEnabled(brokerConfig.isAuthorizationEnabled());
+                workerConfig.setAuthorizationProvider(brokerConfig.getAuthorizationProvider());
+
+                workerConfig.setZooKeeperSessionTimeoutMillis(brokerConfig.getZooKeeperSessionTimeoutMillis());
 
 Review comment:
   Doesn't This violate some abstraction layers here?
   The zkoptimeout is only relevant for default pulsar provider right? In reality this should be basically a call to inherit all the config relevant to that particular auth provider? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services