You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@spark.apache.org by "Takuya Ueshin (Jira)" <ji...@apache.org> on 2021/10/15 00:51:00 UTC

[jira] [Created] (SPARK-37011) Upgrade flake8 to 3.9.0 or above in Jenkins

Takuya Ueshin created SPARK-37011:
-------------------------------------

             Summary: Upgrade flake8 to 3.9.0 or above in Jenkins
                 Key: SPARK-37011
                 URL: https://issues.apache.org/jira/browse/SPARK-37011
             Project: Spark
          Issue Type: Improvement
          Components: PySpark
    Affects Versions: 3.2.0
            Reporter: Haejoon Lee
            Assignee: Shane Knapp
             Fix For: 3.3.0


In flake8 < 3.8.0, F401 error occurs for imports in *if* statements when TYPE_CHECKING is True. However, TYPE_CHECKING is always False at runtime, so there is no need to treat it as an error in static analysis.

Since this behavior is fixed In flake8 >= 3.8.0, we should upgrade the flake8 installed in Jenkins to 3.8.0 or above. Otherwise, it occurs F401 error for several lines in pandas-on-PySpark that uses TYPE_CHECKING.

And also we might update the {{MINIMUM_FLAKE8}} in the {{lint-python}} from 3.5.0 to 3.8.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org