You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/25 01:57:20 UTC

[GitHub] [dolphinscheduler] hiSandog commented on pull request #13273: [Improvement][dao] Optimized countInstanceStateByProjectCodes

hiSandog commented on PR #13273:
URL: https://github.com/apache/dolphinscheduler/pull/13273#issuecomment-1364610668

   > I think this `join` makes sure that the project exist. Similar `join` can be seen in other queries, either.
   
   The only reason the similar join in this file is because the condition of the query is `project id` instead of `project code`.(countInstanceStateV2)
   You need to clear all process_definition before deleting the project.
   Therefore, I think it is unnecessary to guarantee the existence of project by joining t_ds_project table


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org