[jira] [Commented] (FREEMARKER-7) Maven Build

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FREEMARKER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986807#comment-14986807 ] 

ASF GitHub Bot commented on FREEMARKER-7:
-----------------------------------------

GitHub user woonsan opened a pull request:

    https://github.com/apache/incubator-freemarker/pull/8

    FREEMARKER-7 Build with Maven

    Initial PR to build with Maven instead of Ant/Ivy:
    - Adding initial pom.xml with javacc plugin configuration, dependencies, etc.
    - To support multiple incompatible jython versions, I decided to use Reflection APIs for old jython versions because those two classes for the older version of jython APIs are very small and it seems more effective to use Reflection API for those than using complex dependencies and separate compilations.
    - To support older version of jsp-api, I simply added an unsupported operation, by which both versions can work without any problem at runtime, while supporting multiple provided jsp-api versions at runtime. I think this approach is simpler and more effective.
    - Still I noticed that two unit test operations failing (RealServletContainertTest#basicTrivial() and RealServletContainertTest#basicELFunctions()). I think we'd better separate modules for this kind of real web application runtime tests. Until that, I decided to mark those two operations as @Ignore, to also ask for other's opinions.
    
    Anyway, you can run the following command. Then it will create a freemarker-x.x.x.jar in target/ dir:
    ```
        mvn clean package
    ```


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/woonsan/incubator-freemarker feature/FREEMARKER-maven-build

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-freemarker/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8
    
----
commit 3b4bc0eb386d5b151c58f7c39055156c67588d04
Author: Woonsan Ko <wo...@apache.org>
Date:   2015-11-03T06:46:00Z

    FREEMARKER-7 initial maven build support

commit d401ece5a68b9450a9e9677747b1d53a5a58f16f
Author: Woonsan Ko <wo...@apache.org>
Date:   2015-11-03T06:46:16Z

    FREEMARKER-7 initial maven build support

commit ab88e1751fbe4342d6ce384e5b3e9a1459adef99
Author: Woonsan Ko <wo...@apache.org>
Date:   2015-11-03T06:48:00Z

    Merge remote-tracking branch 'upstream/2.3-gae' into feature/FREEMARKER-maven-build

----


> Maven Build
> -----------
>
>                 Key: FREEMARKER-7
>                 URL: https://issues.apache.org/jira/browse/FREEMARKER-7
>             Project: Apache Freemarker
>          Issue Type: New Feature
>            Reporter: Woonsan Ko
>
> Build with Maven instead of Ant/Ivy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)