You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/07/17 18:31:10 UTC
[kudu-CR] [minidump] a minor cleanup on the minidump code
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20206
Change subject: [minidump] a minor cleanup on the minidump code
......................................................................
[minidump] a minor cleanup on the minidump code
I looked through the code of the minidump wrapper in the context of
KUDU-3491 and cleaned up the related sections a bit:
* explicitly initialize the 'user_signal_handler_thread_running_' field
* changed the signature of the minidump_dir() method to return
'const std::string' and perform an extra sanity check (debug-only)
* changed the type from 'int' to 'size_t' and explicitly initialize
the 'current_num_instances_' static member: that's not necessary per
the C++ standard (at least C++17), but might help to work around
possible compiler bugs
* other minor updates: code style, etc.
Change-Id: I33b0c528975bf50a6fe16b9c2f76eeb685e5dd35
---
M src/kudu/util/minidump.cc
M src/kudu/util/minidump.h
2 files changed, 31 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/20206/1
--
To view, visit http://gerrit.cloudera.org:8080/20206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33b0c528975bf50a6fe16b9c2f76eeb685e5dd35
Gerrit-Change-Number: 20206
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [minidump] a minor cleanup on the minidump code
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20206 )
Change subject: [minidump] a minor cleanup on the minidump code
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33b0c528975bf50a6fe16b9c2f76eeb685e5dd35
Gerrit-Change-Number: 20206
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Jul 2023 22:38:08 +0000
Gerrit-HasComments: No
[kudu-CR] [minidump] a minor cleanup on the minidump code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [minidump] a minor cleanup on the minidump code
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I33b0c528975bf50a6fe16b9c2f76eeb685e5dd35
Gerrit-Change-Number: 20206
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
[kudu-CR] [minidump] a minor cleanup on the minidump code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20206 )
Change subject: [minidump] a minor cleanup on the minidump code
......................................................................
[minidump] a minor cleanup on the minidump code
I looked through the code of the minidump wrapper in the context of
KUDU-3491 and cleaned up the related sections a bit:
* explicitly initialize the 'user_signal_handler_thread_running_' field
* changed the signature of the minidump_dir() method to return
'const std::string' and perform an extra sanity check (debug-only)
* changed the type from 'int' to 'size_t' and explicitly initialize
the 'current_num_instances_' static member: that's not necessary per
the C++ standard (at least C++17), but might help to work around
possible compiler bugs
* other minor updates: code style, etc.
Change-Id: I33b0c528975bf50a6fe16b9c2f76eeb685e5dd35
Reviewed-on: http://gerrit.cloudera.org:8080/20206
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/util/minidump.cc
M src/kudu/util/minidump.h
2 files changed, 31 insertions(+), 20 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I33b0c528975bf50a6fe16b9c2f76eeb685e5dd35
Gerrit-Change-Number: 20206
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
[kudu-CR] [minidump] a minor cleanup on the minidump code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20206 )
Change subject: [minidump] a minor cleanup on the minidump code
......................................................................
Patch Set 1: Verified+1
unrelated failure in LocationAwareRebalancingParamTest.Rebalance/idx7_rf2_t3_l_1_2_1; unrelated failure to submit dist-test job (Could not submit C++ distributed test job)
--
To view, visit http://gerrit.cloudera.org:8080/20206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33b0c528975bf50a6fe16b9c2f76eeb685e5dd35
Gerrit-Change-Number: 20206
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jul 2023 00:58:40 +0000
Gerrit-HasComments: No