[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3205: Ensure StructArrays check nullability of fields

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #3205:
URL: https://github.com/apache/arrow-rs/pull/3205#discussion_r1033768581


##########
arrow-array/src/array/mod.rs:
##########
@@ -916,7 +916,7 @@ mod tests {
     #[test]
     fn test_null_struct() {
         let struct_type =
-            DataType::Struct(vec![Field::new("data", DataType::Int64, false)]);
+            DataType::Struct(vec![Field::new("data", DataType::Int64, true)]);

Review Comment:
   This actually highlights a somewhat fun issue that I'm also running into with the row format (#3159), namely how to create a null `StructArray` with children that aren't nullable. I _think_ new_null_array should discard the null mask for its children, but I'm not 100% sure. I need to think a bit more on this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org