[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11334: chore(prophet): ignore logged warning for missing plotly package

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #11334:
URL: https://github.com/apache/incubator-superset/pull/11334#discussion_r508215936



##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -590,6 +591,9 @@ def _prophet_fit_and_predict(  # pylint: disable=too-many-arguments
     Fit a prophet model and return a DataFrame with predicted results.
     """
     try:
+        prophet_logger = logging.getLogger("fbprophet.plot")
+
+        prophet_logger.setLevel(logging.CRITICAL)

Review comment:
       I don't feel strongly about it either, but should we crank the level back up after the import?

##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -590,6 +591,9 @@ def _prophet_fit_and_predict(  # pylint: disable=too-many-arguments
     Fit a prophet model and return a DataFrame with predicted results.
     """
     try:
+        prophet_logger = logging.getLogger("fbprophet.plot")
+
+        prophet_logger.setLevel(logging.CRITICAL)

Review comment:
       I don't feel strongly about it either way, but should we crank the level back up after the import?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org