You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/08/10 17:13:35 UTC
[GitHub] [hadoop] GauthamBanasandra opened a new pull request #2208: HADOOP-17196 Fix C/C++ standard warnings
GauthamBanasandra opened a new pull request #2208:
URL: https://github.com/apache/hadoop/pull/2208
* Passing C/C++ standard flags -std is
not cross-compiler friendly as not all
compilers support all values.
* Thus, we need to make use of the
appropriate flags provided by CMake in
order to specify the C/C++ standards.
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #2208: HADOOP-17196 Fix C/C++ standard warnings
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #2208:
URL: https://github.com/apache/hadoop/pull/2208#issuecomment-671782651
Thank you @GauthamBanasandra for your contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on pull request #2208: HADOOP-17196 Fix C/C++ standard warnings
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on pull request #2208:
URL: https://github.com/apache/hadoop/pull/2208#issuecomment-671743248
@aajisaka could you please review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on pull request #2208: HADOOP-17196 Fix C/C++ standard warnings
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on pull request #2208:
URL: https://github.com/apache/hadoop/pull/2208#issuecomment-671741144
Regarding test4tests, this patch doesn't change any behaviour thus adding/modifying tests isn't necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka merged pull request #2208: HADOOP-17196 Fix C/C++ standard warnings
Posted by GitBox <gi...@apache.org>.
aajisaka merged pull request #2208:
URL: https://github.com/apache/hadoop/pull/2208
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on pull request #2208: HADOOP-17196 Fix C/C++ standard warnings
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on pull request #2208:
URL: https://github.com/apache/hadoop/pull/2208#issuecomment-671740422
The cc warnings in the above CI run are not introduced by my patch. They're due to the existing code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2208: HADOOP-17196 Fix C/C++ standard warnings
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2208:
URL: https://github.com/apache/hadoop/pull/2208#issuecomment-671574935
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 3m 25s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 29m 28s | trunk passed |
| +1 :green_heart: | compile | 24m 7s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | compile | 20m 16s | trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| +1 :green_heart: | mvnsite | 2m 9s | trunk passed |
| +1 :green_heart: | shadedclient | 97m 34s | branch has no errors when building and testing our client artifacts. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 17s | the patch passed |
| +1 :green_heart: | compile | 22m 29s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| -1 :x: | cc | 22m 29s | root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 34 new + 128 unchanged - 34 fixed = 162 total (was 162) |
| +1 :green_heart: | javac | 22m 29s | the patch passed |
| +1 :green_heart: | compile | 20m 35s | the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| -1 :x: | cc | 20m 35s | root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 generated 16 new + 146 unchanged - 16 fixed = 162 total (was 162) |
| +1 :green_heart: | javac | 20m 35s | the patch passed |
| +1 :green_heart: | mvnsite | 2m 10s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 16m 43s | patch has no errors when building and testing our client artifacts. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 10m 16s | hadoop-common in the patch passed. |
| +1 :green_heart: | unit | 9m 32s | hadoop-hdfs-native-client in the patch passed. |
| +1 :green_heart: | asflicense | 0m 57s | The patch does not generate ASF License warnings. |
| | | 186m 59s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2208/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2208 |
| Optional Tests | dupname asflicense compile cc mvnsite javac unit |
| uname | Linux 0fe2e6bd1b48 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 5e0f8797790 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2208/1/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
| cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2208/1/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2208/1/testReport/ |
| Max. process+thread count | 2017 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-native-client U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2208/1/console |
| versions | git=2.17.1 maven=3.6.0 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org